NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit09f8421

committed

pg_dump: Don't leak memory in buildDefaultACLCommands()

buildDefaultACLCommands() didn't destroy the string buffer created incertain cases, leading to a memory leak. Fix by destroying the bufferbefore returning from the function.Spotted by Coverity.Author: Michael PaquierBack-patch to 9.6 where buildDefaultACLCommands() was added.

1 parentaa5d3c0 commit09f8421Copy full SHA for 09f8421

File tree

1 file changed

-0

lines changed

src/bin/pg_dump
- dumputils.c

1 file changed

-0

lines changed

`‎src/bin/pg_dump/dumputils.c`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -390,13 +390,19 @@ buildDefaultACLCommands(const char type, const char nspname,`
`390`	`390`	`appendPQExpBuffer(sql,"SELECT pg_catalog.binary_upgrade_set_record_init_privs(true);\n");`
`391`	`391`	`if (!buildACLCommands("",NULL,type,initacls,initracls,owner,`
`392`	`392`	`prefix->data,remoteVersion,sql))`
	`393`	`+{`
	`394`	`+destroyPQExpBuffer(prefix);`
`393`	`395`	`return false;`
	`396`	`+}`
`394`	`397`	`appendPQExpBuffer(sql,"SELECT pg_catalog.binary_upgrade_set_record_init_privs(false);\n");`
`395`	`398`	`}`
`396`	`399`
`397`	`400`	`if (!buildACLCommands("",NULL,type,acls,racls,owner,`
`398`	`401`	`prefix->data,remoteVersion,sql))`
	`402`	`+{`
	`403`	`+destroyPQExpBuffer(prefix);`
`399`	`404`	`return false;`
	`405`	`+}`
`400`	`406`
`401`	`407`	`destroyPQExpBuffer(prefix);`
`402`	`408`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit09f8421

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/dumputils.c`

0 commit comments