NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit09d1110

Neil Conway

committed

Trivial dead code removal: in CreateSchemaCommand(), 'owner_name' is

only used in one branch of an if statement, so we can move itsdeclaration to that block. This also avoids an unnecessary syscachelookup.Per Coverity static analysis performed by EnterpriseDB.

1 parent2d4b973 commit09d1110Copy full SHA for 09d1110

File tree

1 file changed

-5

lines changed

src/backend/commands
- schemacmds.c

1 file changed

-5

lines changed

`‎src/backend/commands/schemacmds.c`

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/schemacmds.c,v 1.29 2005/04/14 20:03:24 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/schemacmds.c,v 1.30 2005/06/21 00:58:15 neilc Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -42,7 +42,6 @@ CreateSchemaCommand(CreateSchemaStmt *stmt)`
`42`	`42`	`OidnamespaceId;`
`43`	`43`	`List*parsetree_list;`
`44`	`44`	`ListCell*parsetree_item;`
`45`		`-constchar*owner_name;`
`46`	`45`	`AclIdowner_userid;`
`47`	`46`	`AclIdsaved_userid;`
`48`	`47`	`AclResultaclresult;`
`@@ -56,13 +55,11 @@ CreateSchemaCommand(CreateSchemaStmt *stmt)`
`56`	`55`	`if (!authId)`
`57`	`56`	`{`
`58`	`57`	`owner_userid=saved_userid;`
`59`		`-owner_name=GetUserNameFromId(owner_userid);`
`60`	`58`	`}`
`61`	`59`	`elseif (superuser())`
`62`	`60`	`{`
`63`		`-owner_name=authId;`
`64`	`61`	`/* The following will error out if user does not exist */`
`65`		`-owner_userid=get_usesysid(owner_name);`
	`62`	`+owner_userid=get_usesysid(authId);`
`66`	`63`
`67`	`64`	`/*`
`68`	`65`	`* Set the current user to the requested authorization so that`
`@@ -74,6 +71,8 @@ CreateSchemaCommand(CreateSchemaStmt *stmt)`
`74`	`71`	`}`
`75`	`72`	`else`
`76`	`73`	`{`
	`74`	`+constchar*owner_name;`
	`75`	`+`
`77`	`76`	`/* not superuser */`
`78`	`77`	`owner_userid=saved_userid;`
`79`	`78`	`owner_name=GetUserNameFromId(owner_userid);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit09d1110

File tree

1 file changed

1 file changed

`‎src/backend/commands/schemacmds.c`

0 commit comments