Commit096f1cc

committed

Always initialize PartitionBoundInfoData's null_index.

This doesn't actually matter at present, because the current codenever consults null_index for range partitions. However, leavingit uninitialized is still a bad idea, so let's not do that.Amul Sul, reviewed by Ashutosh BapatDiscussion:http://postgr.es/m/CAAJ_b94AkEzcx+12ySCnbMDX7=UdF4BjnoBGfMQbB0RNSTo3Ng@mail.gmail.com

1 parentb6263cd commit096f1ccCopy full SHA for 096f1cc

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -454,6 +454,7 @@ RelationBuildPartitionDesc(Relation rel)`
`454`	`454`	`palloc0(sizeof(PartitionBoundInfoData));`
`455`	`455`	`boundinfo->strategy=key->strategy;`
`456`	`456`	`boundinfo->ndatums=ndatums;`
	`457`	`+boundinfo->null_index=-1;`
`457`	`458`	`boundinfo->datums= (Datum*)palloc0(ndatumssizeof(Datum*));`
`458`	`459`
`459`	`460`	`/* Initialize mapping array with invalid values */`
`@@ -503,8 +504,6 @@ RelationBuildPartitionDesc(Relation rel)`
`503`	`504`	`mapping[null_index]=next_index++;`
`504`	`505`	`boundinfo->null_index=mapping[null_index];`
`505`	`506`	`}`
`506`		`-else`
`507`		`-boundinfo->null_index=-1;`
`508`	`507`
`509`	`508`	`/* All partition must now have a valid mapping */`
`510`	`509`	`Assert(next_index==nparts);`

Comments

(0)