Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit096bbf7

Browse files
committed
Switch back sslcompression to be a normal input field in libpq
Per buildfarm member crake, any servers including a postgres_fdw serverwith this option set would fail to do a pg_upgrade properly as theoption got hidden inf9264d1 by becoming a debug option, making therestore of the FDW server fail.This changes back the option in libpq to be visible, but still inactiveto fix this upgrade issue.Discussion:https://postgr.es/m/YEbq15JKJwIX+S6m@paquier.xyz
1 parentff99918 commit096bbf7

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

‎contrib/postgres_fdw/expected/postgres_fdw.out

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ ALTER SERVER testserver1 OPTIONS (
167167
sslcert 'value',
168168
sslkey 'value',
169169
sslrootcert 'value',
170+
sslcompression 'value',
170171
sslcrl 'value',
171172
--requirepeer 'value',
172173
krbsrvname 'value',
@@ -8945,7 +8946,7 @@ DO $d$
89458946
END;
89468947
$d$;
89478948
ERROR: invalid option "password"
8948-
HINT: Valid options in this context are: service, passfile, channel_binding, connect_timeout, dbname, host, hostaddr, port, options, application_name, keepalives, keepalives_idle, keepalives_interval, keepalives_count, tcp_user_timeout, sslmode, sslcert, sslkey, sslrootcert, sslcrl, sslcrldir, requirepeer, ssl_min_protocol_version, ssl_max_protocol_version, gssencmode, krbsrvname, gsslib, target_session_attrs, use_remote_estimate, fdw_startup_cost, fdw_tuple_cost, extensions, updatable, fetch_size, batch_size
8949+
HINT: Valid options in this context are: service, passfile, channel_binding, connect_timeout, dbname, host, hostaddr, port, options, application_name, keepalives, keepalives_idle, keepalives_interval, keepalives_count, tcp_user_timeout, sslmode,sslcompression,sslcert, sslkey, sslrootcert, sslcrl, sslcrldir, requirepeer, ssl_min_protocol_version, ssl_max_protocol_version, gssencmode, krbsrvname, gsslib, target_session_attrs, use_remote_estimate, fdw_startup_cost, fdw_tuple_cost, extensions, updatable, fetch_size, batch_size
89498950
CONTEXT: SQL statement "ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw')"
89508951
PL/pgSQL function inline_code_block line 3 at EXECUTE
89518952
-- If we add a password for our user mapping instead, we should get a different

‎contrib/postgres_fdw/sql/postgres_fdw.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ ALTER SERVER testserver1 OPTIONS (
181181
sslcert'value',
182182
sslkey'value',
183183
sslrootcert'value',
184+
sslcompression'value',
184185
sslcrl'value',
185186
--requirepeer 'value',
186187
krbsrvname'value',

‎src/interfaces/libpq/fe-connect.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ static const internalPQconninfoOption PQconninfoOptions[] = {
298298
* compatibility.
299299
*/
300300
{"sslcompression",NULL,NULL,NULL,
301-
"SSL-Compression","D",1,-1},
301+
"SSL-Compression","",1,-1},
302302

303303
{"sslcert","PGSSLCERT",NULL,NULL,
304304
"SSL-Client-Cert","",64,

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp