Commit09391dd

committed

Fix type of iterator variable in SH_START_ITERATE

Also add comment to make the reasoning behind the Assert() more explicit (perTom).Reported-by: Ranier VilelaDiscussion:https://postgr.es/m/CAEudQAocXNJ6s1VLz+hMamLAQAiewRoW17OJ6-+9GACKfj6iPQ@mail.gmail.comBackpatch: 11-

1 parent9ebe6fd commit09391ddCopy full SHA for 09391dd

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -840,15 +840,14 @@ SH_DELETE(SH_TYPE * tb, SH_KEY_TYPE key)`
`840`	`840`	`SH_SCOPEvoid`
`841`	`841`	`SH_START_ITERATE(SH_TYPEtb,SH_ITERATORiter)`
`842`	`842`	`{`
`843`		`-inti;`
`844`	`843`	`uint64startelem=PG_UINT64_MAX;`
`845`	`844`
`846`	`845`	`/*`
`847`	`846`	`* Search for the first empty element. As deletions during iterations are`
`848`	`847`	`* supported, we want to start/end at an element that cannot be affected`
`849`	`848`	`* by elements being shifted.`
`850`	`849`	`*/`
`851`		`-for (i=0;i<tb->size;i++)`
	`850`	`+for (uint32i=0;i<tb->size;i++)`
`852`	`851`	`{`
`853`	`852`	`SH_ELEMENT_TYPE*entry=&tb->data[i];`
`854`	`853`
`@@ -859,6 +858,7 @@ SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter)`
`859`	`858`	`}`
`860`	`859`	`}`
`861`	`860`
	`861`	`+/* we should have found an empty element */`
`862`	`862`	`Assert(startelem<SH_MAX_SIZE);`
`863`	`863`
`864`	`864`	`/*`

Comments

(0)