Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0927bf8

Browse files
committed
Guard against bad "dscale" values in numeric_recv().
We were not checking to see if the supplied dscale was valid for the givendigit array when receiving binary-format numeric values. While dscale canvalidly be more than the number of nonzero fractional digits, it shouldn'tbe less; that case causes fractional digits to be hidden on display eventhough they're there and participate in arithmetic.Bug #12053 from Tommaso Sala indicates that there's at least one brokenclient library out there that sometimes supplies an incorrect dscale value,leading to strange behavior. This suggests that simply throwing an errormight not be the best response; it would lead to failures in applicationsthat might seem to be working fine today. What seems the least risky fixis to truncate away any digits that would be hidden by dscale. Thispreserves the existing behavior in terms of what will be printed for thetransmitted value, while preventing subsequent arithmetic from producingresults inconsistent with that.In passing, throw a specific error for the case of dscale being outsidethe range that will fit into a numeric's header. Before you got "valueoverflows numeric format", which is a bit misleading.Back-patch to all supported branches.
1 parentdf761e3 commit0927bf8

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

‎src/backend/utils/adt/numeric.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -717,6 +717,8 @@ numeric_recv(PG_FUNCTION_ARGS)
717717
alloc_var(&value,len);
718718

719719
value.weight= (int16)pq_getmsgint(buf,sizeof(int16));
720+
/* we allow any int16 for weight --- OK? */
721+
720722
value.sign= (uint16)pq_getmsgint(buf,sizeof(uint16));
721723
if (!(value.sign==NUMERIC_POS||
722724
value.sign==NUMERIC_NEG||
@@ -726,6 +728,11 @@ numeric_recv(PG_FUNCTION_ARGS)
726728
errmsg("invalid sign in external \"numeric\" value")));
727729

728730
value.dscale= (uint16)pq_getmsgint(buf,sizeof(uint16));
731+
if ((value.dscale&NUMERIC_DSCALE_MASK)!=value.dscale)
732+
ereport(ERROR,
733+
(errcode(ERRCODE_INVALID_BINARY_REPRESENTATION),
734+
errmsg("invalid scale in external \"numeric\" value")));
735+
729736
for (i=0;i<len;i++)
730737
{
731738
NumericDigitd=pq_getmsgint(buf,sizeof(NumericDigit));
@@ -737,6 +744,14 @@ numeric_recv(PG_FUNCTION_ARGS)
737744
value.digits[i]=d;
738745
}
739746

747+
/*
748+
* If the given dscale would hide any digits, truncate those digits away.
749+
* We could alternatively throw an error, but that would take a bunch of
750+
* extra code (about as much as trunc_var involves), and it might cause
751+
* client compatibility issues.
752+
*/
753+
trunc_var(&value,value.dscale);
754+
740755
apply_typmod(&value,typmod);
741756

742757
res=make_result(&value);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp