Movatterモバイル変換

Skip to content

postgrespro/postgresPublic

forked frompostgres/postgres

NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0896ae5

michaelpq

committed

Fix inconsistencies and typos in the tree

This is numbered take 7, and addresses a set of issues around:- Fixes for typos and incorrect reference names.- Removal of unneeded comments.- Removal of unreferenced functions and structures.- Fixes regarding variable name consistency.Author: Alexander LakhinDiscussion:https://postgr.es/m/10bfd4ac-3e7c-40ab-2b2e-355ed15495e8@gmail.com

1 parent4c3d05d commit0896ae5Copy full SHA for 0896ae5

File tree

41 files changed

+55

-84

lines changed

contrib
- cube
  - cube.c
- intarray
  - _int.h
- ltree
  - ltxtquery_io.c
- pgstattuple
  - pgstatindex.c
doc/src/sgml
- gist.sgml
src
- backend
  - access
    - gin
      - README
      - ginfast.c
    - gist
      - README
      - gist.c
    - nbtree
      - README
    - spgist
      - spgscan.c
    - transam
      - clog.c
  - bootstrap
    - bootstrap.c
  - catalog
    - namespace.c
  - executor
    - nodeAgg.c
  - optimizer/prep
    - prepunion.c
  - parser
    - parse_agg.c
  - rewrite
    - rewriteManip.c
  - storage
    - buffer
      - bufmgr.c
    - file
      - buffile.c
      - fd.c
    - freespace
      - freespace.c
    - lmgr
      - lock.c
      - predicate.c
  - utils
    - adt
    - mmgr
      - dsa.c
- bin
  - pg_dump
    - pg_dump.c
    - pg_dump.h
  - pg_upgrade
    - pg_upgrade.c
- include
  - access
    - gist_private.h
    - xlog_internal.h
  - foreign
    - foreign.h
  - postmaster
    - postmaster.h
  - storage
    - fsm_internals.h
    - predicate_internals.h
- interfaces/ecpg
  - compatlib
    - informix.c
  - pgtypeslib
    - dt_common.c
- port
  - thread.c
- test/perl
  - TestLib.pm

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+55

-84

lines changed

`‎contrib/cube/cube.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ boolg_cube_leaf_consistent(NDBOX key, NDBOX query, StrategyNumber strategy);`
`100`	`100`	`boolg_cube_internal_consistent(NDBOXkey,NDBOXquery,StrategyNumberstrategy);`
`101`	`101`
`102`	`102`	`/*`
`103`		`-** Auxiliaryfunxtions`
	`103`	`+** Auxiliaryfunctions`
`104`	`104`	`*/`
`105`	`105`	`staticdoubledistance_1D(doublea1,doublea2,doubleb1,doubleb2);`
`106`	`106`	`staticboolcube_is_point_internal(NDBOX*cube);`

`‎contrib/intarray/_int.h‎`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -85,12 +85,6 @@ typedef struct`
`85`	`85`
`86`	`86`	`#defineGETSIGN(x)( (BITVECP)( (char*)x+GTHDRSIZE ) )`
`87`	`87`
`88`		`-/*`
`89`		`- * types for functions`
`90`		`- */`
`91`		`-typedefArrayType(formarray) (ArrayType,ArrayType);`
`92`		`-typedefvoid (formfloat) (ArrayType,float*);`
`93`		`-`
`94`	`88`	`/*`
`95`	`89`	`* useful functions`
`96`	`90`	`*/`

`‎contrib/ltree/ltxtquery_io.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,7 @@ queryin(char *buf)`
`368`	`368`	`state.str=tmp;`
`369`	`369`	`}`
`370`	`370`
`371`		`-/* set user friendly-operand view */`
	`371`	`+/* set user-friendlyoperand view */`
`372`	`372`	`memcpy((void)GETOPERAND(query), (void)state.op,state.sumlen);`
`373`	`373`	`pfree(state.op);`
`374`	`374`

`‎contrib/pgstattuple/pgstatindex.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -727,7 +727,7 @@ pgstathashindex(PG_FUNCTION_ARGS)`
`727`	`727`	`}`
`728`	`728`
`729`	`729`	`/* -------------------------------------------------`
`730`		`- *GetHashPageStatis()`
	`730`	`+ *GetHashPageStats()`
`731`	`731`	`*`
`732`	`732`	`* Collect statistics of single hash page`
`733`	`733`	`* -------------------------------------------------`

`‎doc/src/sgml/gist.sgml‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -922,7 +922,7 @@ my_fetch(PG_FUNCTION_ARGS)`
`922`	`922`	`* Convert 'fetched_data' into the a Datum of the original datatype.`
`923`	`923`	`*/`
`924`	`924`
`925`		`- /* fill retval fromfetch_data. /`
	`925`	`+ /* fill retval fromfetched_data. /`
`926`	`926`	`gistentryinit(*retval, PointerGetDatum(converted_datum),`
`927`	`927`	`entry->rel, entry->page, entry->offset, FALSE);`
`928`	`928`

`‎src/backend/access/gin/README‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ algorithms.`
`163`	`163`
`164`	`164`	`* The posting list can be accessed with GinGetPosting(itup)`
`165`	`165`
`166`		`-* IfGinITupIsCompressed(itup), the posting list is stored in compressed`
	`166`	`+* IfGinItupIsCompressed(itup), the posting list is stored in compressed`
`167`	`167`	`format. Otherwise it is just an array of ItemPointers. New tuples are always`
`168`	`168`	`stored in compressed format, uncompressed items can be present if the`
`169`	`169`	`database was migrated from 9.3 or earlier version.`

`‎src/backend/access/gin/ginfast.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1013,7 +1013,7 @@ ginInsertCleanup(GinState *ginstate, bool full_clean,`
`1013`	`1013`
`1014`	`1014`	`/*`
`1015`	`1015`	`* As pending list pages can have a high churn rate, it is desirable to`
`1016`		`- * recycle them immediately to theFreeSpace Map when ordinary backends`
	`1016`	`+ * recycle them immediately to theFreeSpaceMap when ordinary backends`
`1017`	`1017`	`* clean the list.`
`1018`	`1018`	`*/`
`1019`	`1019`	`if (fsm_vac&&fill_fsm)`

`‎src/backend/access/gist/README‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ it splits the page, and constructs the new downlink tuples for the split`
`170`	`170`	`pages. The caller must then call gistplacetopage() on the parent page to`
`171`	`171`	`insert the downlink tuples. The parent page that holds the downlink to`
`172`	`172`	`the child might have migrated as a result of concurrent splits of the`
`173`		`-parent,gistfindCorrectParent() is used to find the parent page.`
	`173`	`+parent,gistFindCorrectParent() is used to find the parent page.`
`174`	`174`
`175`	`175`	`Splitting the root page works slightly differently. At root split,`
`176`	`176`	`gistplacetopage() allocates the new child pages and replaces the old root`

`‎src/backend/access/gist/gist.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -821,7 +821,7 @@ gistdoinsert(Relation r, IndexTuple itup, Size freespace,`
`821`	`821`	`/*`
`822`	`822`	`* Leaf page. Insert the new key. We've already updated all the`
`823`	`823`	`* parents on the way down, but we might have to split the page if`
`824`		`- * it doesn't fit.gistinserthere() will take care of that.`
	`824`	`+ * it doesn't fit.gistinserttuple() will take care of that.`
`825`	`825`	`*/`
`826`	`826`
`827`	`827`	`/*`

`‎src/backend/access/nbtree/README‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -457,7 +457,7 @@ right sibling's left-link --- followed by a second WAL entry for the`
`457`	`457`	`insertion on the parent level (which might itself be a page split, requiring`
`458`	`458`	`an additional insertion above that, etc).`
`459`	`459`
`460`		`-For a root split, thefollowon WAL entry is a "new root" entry rather than`
	`460`	`+For a root split, thefollow-on WAL entry is a "new root" entry rather than`
`461`	`461`	`an "insertion" entry, but details are otherwise much the same.`
`462`	`462`
`463`	`463`	`Because splitting involves multiple atomic actions, it's possible that the`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp