NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit088f8e2

committed

Assert that wrapper_handler()'s argument is within expected range.

pqsignal() already does a similar check, but strange Valgrindreports have us wondering if wrapper_handler() is somehow gettingcalled with an invalid signal number.Reported-by: Tomas Vondra <tomas@vondra.me>Suggested-by: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/ace01111-f9ac-4f61-b1b1-8e9379415444%40vondra.meBackpatch-through: 17

1 parent34c3c5c commit088f8e2Copy full SHA for 088f8e2

File tree

1 file changed

-0

lines changed

src/port
- pqsignal.c

1 file changed

-0

lines changed

`‎src/port/pqsignal.c‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,9 @@ wrapper_handler(SIGNAL_ARGS)`
`87`	`87`	`{`
`88`	`88`	`intsave_errno=errno;`
`89`	`89`
	`90`	`+Assert(postgres_signal_arg>0);`
	`91`	`+Assert(postgres_signal_arg<PG_NSIG);`
	`92`	`+`
`90`	`93`	`#ifndefFRONTEND`
`91`	`94`
`92`	`95`	`/*`
`@@ -123,6 +126,7 @@ pqsignal(int signo, pqsigfunc func)`
`123`	`126`	`structsigactionact;`
`124`	`127`	`#endif`
`125`	`128`
	`129`	`+Assert(signo>0);`
`126`	`130`	`Assert(signo<PG_NSIG);`
`127`	`131`
`128`	`132`	`if (func!=SIG_IGN&&func!=SIG_DFL)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit088f8e2

File tree

1 file changed

1 file changed

`‎src/port/pqsignal.c‎`

0 commit comments