NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit08882ce

committed

Reduce CPU utilisation of WALSender process. Process was using 10% CPU

doing nothing, caused by naptime specified in milliseconds yet units ofpg_usleep() parameter is microseconds. Correctly specifying unitsreduces call frequency by 1000. Reduction in CPU consumption verified.

1 parent16a4186 commit08882ceCopy full SHA for 08882ce

File tree

1 file changed

-3

lines changed

src/backend/replication
- walsender.c

1 file changed

-3

lines changed

`‎src/backend/replication/walsender.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`*`
`31`	`31`	`*`
`32`	`32`	`* IDENTIFICATION`
`33`		`- * $PostgreSQL: pgsql/src/backend/replication/walsender.c,v 1.10 2010/03/16 09:09:55 heikki Exp $`
	`33`	`+ * $PostgreSQL: pgsql/src/backend/replication/walsender.c,v 1.11 2010/03/24 20:11:12 sriggs Exp $`
`34`	`34`	`*`
`35`	`35`	`*-------------------------------------------------------------------------`
`36`	`36`	`*/`
`@@ -67,7 +67,7 @@ boolam_walsender = false;/* Am I a walsender process ? */`
`67`	`67`	`intMaxWalSenders=0;/* the maximum number of concurrent walsenders */`
`68`	`68`	`intWalSndDelay=200;/* max sleep time between some actions */`
`69`	`69`
`70`		`-#defineNAPTIME_PER_CYCLE100/* max sleep time between cycles (100ms) */`
	`70`	`+#defineNAPTIME_PER_CYCLE100000L/* max sleep time between cycles (100ms) */`
`71`	`71`
`72`	`72`	`/*`
`73`	`73`	`* These variables are used similarly to openLogFile/Id/Seg/Off,`
`@@ -396,7 +396,7 @@ WalSndLoop(void)`
`396`	`396`	`* sleep into NAPTIME_PER_CYCLE (ms) increments, and check for`
`397`	`397`	`* interrupts after each nap.`
`398`	`398`	`*/`
`399`		`-remain=WalSndDelay;`
	`399`	`+remain=WalSndDelay*1000L;`
`400`	`400`	`while (remain>0)`
`401`	`401`	`{`
`402`	`402`	`if (got_SIGHUP\|\|shutdown_requested\|\|ready_to_stop)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit08882ce

File tree

1 file changed

1 file changed

`‎src/backend/replication/walsender.c`

0 commit comments