Commit08195a4

committed

Fix bugs in NUMERIC ceil() and floor() functions. ceil(0) returned 1,

and both would insert random junk digits if given an input that was anexact multiple of 10.

1 parent6d1efd7 commit08195a4Copy full SHA for 08195a4

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`*1998 Jan Wieck`
`7`	`7`	`*`
`8`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/numeric.c,v 1.23 2000/01/18 03:44:41 tgl Exp $`
	`8`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/numeric.c,v 1.24 2000/01/20 02:21:44 tgl Exp $`
`9`	`9`	`*`
`10`	`10`	`* ----------`
`11`	`11`	`*/`
`@@ -2932,7 +2932,7 @@ ceil_var(NumericVar var, NumericVar result)`
`2932`	`2932`	`set_var_from_var(var,&tmp);`
`2933`	`2933`
`2934`	`2934`	`tmp.rscale=0;`
`2935`		`-tmp.ndigits=MAX(0,tmp.weight+1);`
	`2935`	`+tmp.ndigits=MIN(tmp.ndigits,MAX(0,tmp.weight+1));`
`2936`	`2936`	`if (tmp.sign==NUMERIC_POS&&cmp_var(var,&tmp)!=0)`
`2937`	`2937`	`add_var(&tmp,&const_one,&tmp);`
`2938`	`2938`
`@@ -2957,7 +2957,7 @@ floor_var(NumericVar var, NumericVar result)`
`2957`	`2957`	`set_var_from_var(var,&tmp);`
`2958`	`2958`
`2959`	`2959`	`tmp.rscale=0;`
`2960`		`-tmp.ndigits=MAX(0,tmp.weight+1);`
	`2960`	`+tmp.ndigits=MIN(tmp.ndigits,MAX(0,tmp.weight+1));`
`2961`	`2961`	`if (tmp.sign==NUMERIC_NEG&&cmp_var(var,&tmp)!=0)`
`2962`	`2962`	`sub_var(&tmp,&const_one,&tmp);`
`2963`	`2963`

Comments

(0)