Commit07c4b6a

committed

Fix EXTRACT(ISOYEAR FROM timestamp) for years BC.

The test cases added by commit26ae3aa exposed an old oversight intimestamp[tz]_part: they didn't correct the result of date2isoyear()for BC years, so that we produced an off-by-one answer for such years.Fix that, and back-patch to all supported branches.Discussion:https://postgr.es/m/SG2PR06MB37762CAE45DB0F6CA7001EA9B6550@SG2PR06MB3776.apcprd06.prod.outlook.com

1 parent7335563 commit07c4b6aCopy full SHA for 07c4b6a

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4359,6 +4359,7 @@ date2isoweek(int year, int mon, int mday)`
`4359`	`4359`	`/* date2isoyear()`
`4360`	`4360`	`*`
`4361`	`4361`	`*Returns ISO 8601 year number.`
	`4362`	`+ *Note: zero or negative results follow the year-zero-exists convention.`
`4362`	`4363`	`*/`
`4363`	`4364`	`int`
`4364`	`4365`	`date2isoyear(intyear,intmon,intmday)`
`@@ -4633,6 +4634,9 @@ timestamp_part(PG_FUNCTION_ARGS)`
`4633`	`4634`
`4634`	`4635`	`caseDTK_ISOYEAR:`
`4635`	`4636`	`result=date2isoyear(tm->tm_year,tm->tm_mon,tm->tm_mday);`
	`4637`	`+/* Adjust BC years */`
	`4638`	`+if (result <=0)`
	`4639`	`+result-=1;`
`4636`	`4640`	`break;`
`4637`	`4641`
`4638`	`4642`	`caseDTK_DOW:`
`@@ -4829,6 +4833,9 @@ timestamptz_part(PG_FUNCTION_ARGS)`
`4829`	`4833`
`4830`	`4834`	`caseDTK_ISOYEAR:`
`4831`	`4835`	`result=date2isoyear(tm->tm_year,tm->tm_mon,tm->tm_mday);`
	`4836`	`+/* Adjust BC years */`
	`4837`	`+if (result <=0)`
	`4838`	`+result-=1;`
`4832`	`4839`	`break;`
`4833`	`4840`
`4834`	`4841`	`caseDTK_DOW:`

Lines changed: 1 addition & 1 deletion

Lines changed: 1 addition & 1 deletion

Comments

(0)