NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit07abcd9

committed

Fix error reporting after ioctl() call with pg_upgrade --clone

errno was not reported correctly after attempting to clone a file,leading to incorrect error reports. While scanning through the code, Ihave not noticed any similar mistakes.Error introduced in3a769d8.Author: Justin PryzbyDiscussion:https://postgr.es/m/20220731134135.GY15006@telsasoft.comBackpatch-through: 12

1 parentfeae5c0 commit07abcd9Copy full SHA for 07abcd9

File tree

1 file changed

-1

lines changed

src/bin/pg_upgrade
- file.c

1 file changed

-1

lines changed

`‎src/bin/pg_upgrade/file.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,11 @@ cloneFile(const char src, const char dst,`
`57`	`57`
`58`	`58`	`if (ioctl(dest_fd,FICLONE,src_fd)<0)`
`59`	`59`	`{`
	`60`	`+intsave_errno=errno;`
	`61`	`+`
`60`	`62`	`unlink(dst);`
`61`	`63`	`pg_fatal("error while cloning relation \"%s.%s\" (\"%s\" to \"%s\"): %s\n",`
`62`		`-schemaName,relName,src,dst,strerror(errno));`
	`64`	`+schemaName,relName,src,dst,strerror(save_errno));`
`63`	`65`	`}`
`64`	`66`
`65`	`67`	`close(src_fd);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit07abcd9

File tree

1 file changed

1 file changed

`‎src/bin/pg_upgrade/file.c`

0 commit comments