NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit07672d4

committed

Skip setsockopt(SO_REUSEADDR) for the Unix-domain postmaster socket on

all platforms, not just SCO. The operation is undefined for Unix-domainsockets anyway. It seems SCO is not the only platform that complainsinstead of treating the call as a no-op.

1 parentbf00aec commit07672d4Copy full SHA for 07672d4

File tree

2 files changed

-9

lines changed

src
- backend/libpq
  - pqcomm.c
- include/port
  - sco.h

2 files changed

-9

lines changed

`‎src/backend/libpq/pqcomm.c`

Lines changed: 1 addition & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`* Portions Copyright (c) 1996-2000, PostgreSQL, Inc`
`30`	`30`	`* Portions Copyright (c) 1994, Regents of the University of California`
`31`	`31`	`*`
`32`		`- *$Id: pqcomm.c,v 1.88 2000/04/12 17:15:14 momjian Exp $`
	`32`	`+ *$Id: pqcomm.c,v 1.89 2000/04/14 00:51:58 tgl Exp $`
`33`	`33`	`*`
`34`	`34`	`*-------------------------------------------------------------------------`
`35`	`35`	`*/`
`@@ -205,11 +205,8 @@ StreamServerPort(char hostName, unsigned short portName, int fdP)`
`205`	`205`	`returnSTATUS_ERROR;`
`206`	`206`	`}`
`207`	`207`
`208`		`-#ifdefONLY_REUSE_INET_SOCKETS`
`209`	`208`	`if (family==AF_INET)`
`210`	`209`	`{`
`211`		`-#endif`
`212`		`-`
`213`	`210`	`if ((setsockopt(fd,SOL_SOCKET,SO_REUSEADDR, (char*)&one,`
`214`	`211`	`sizeof(one)))==-1)`
`215`	`212`	`{`
`@@ -220,10 +217,7 @@ StreamServerPort(char hostName, unsigned short portName, int fdP)`
`220`	`217`	`pqdebug("%s",PQerrormsg);`
`221`	`218`	`returnSTATUS_ERROR;`
`222`	`219`	`}`
`223`		`-`
`224`		`-#ifdefONLY_REUSE_INET_SOCKETS`
`225`	`220`	`}`
`226`		`-#endif`
`227`	`221`
`228`	`222`	`MemSet((char*)&saddr,0,sizeof(saddr));`
`229`	`223`	`saddr.sa.sa_family=family;`

`‎src/include/port/sco.h`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,6 @@`
`2`	`2`	`#defineNOFILENOFILES_MIN`
`3`	`3`	`#endif`
`4`	`4`
`5`		`-#defineONLY_REUSE_INET_SOCKETS`
`6`		`-`
`7`	`5`	`#defineDISABLE_COMPLEX_MACRO`
`8`	`6`
`9`	`7`	`#defineUSE_POSIX_TIME`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit07672d4

File tree

2 files changed

2 files changed

`‎src/backend/libpq/pqcomm.c`

`‎src/include/port/sco.h`

0 commit comments