NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0765b2f

committed

Use OFFSET 0 instead of ORDER BY to stop subquery pullup

b762fed recently changed this test to prevent subquery pullup to allowus to test Memoize with lateral_vars. As pointed out by Tom Lane, OFFSET0 is our standard way of preventing subquery pullups, so do it that wayinstead.Discussion:https://postgr.es/m/2144818.1674517061@sss.pgh.pa.usBackpatch-through: 14, same asb762fed

1 parentbcec089 commit0765b2fCopy full SHA for 0765b2f

File tree

2 files changed

-4

lines changed

src/test/regress
- expected
  - memoize.out
- sql
  - memoize.sql

2 files changed

-4

lines changed

`‎src/test/regress/expected/memoize.out‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ WHERE t2.unique1 < 1000;`
`64`	`64`	`SELECT explain_memoize('`
`65`	`65`	`SELECT COUNT(*),AVG(t2.unique1) FROM tenk1 t1,`
`66`	`66`	`LATERAL (SELECT t2.unique1 FROM tenk1 t2`
`67`		`- WHERE t1.twenty = t2.unique1ORDER BY 1) t2`
	`67`	`+ WHERE t1.twenty = t2.unique1OFFSET 0) t2`
`68`	`68`	`WHERE t1.unique1 < 1000;', false);`
`69`	`69`	`explain_memoize`
`70`	`70`	`-------------------------------------------------------------------------------------------`
`@@ -85,7 +85,7 @@ WHERE t1.unique1 < 1000;', false);`
`85`	`85`	`-- And check we get the expected results.`
`86`	`86`	`SELECT COUNT(*),AVG(t2.unique1) FROM tenk1 t1,`
`87`	`87`	`LATERAL (SELECT t2.unique1 FROM tenk1 t2`
`88`		`- WHERE t1.twenty = t2.unique1ORDER BY 1) t2`
	`88`	`+ WHERE t1.twenty = t2.unique1OFFSET 0) t2`
`89`	`89`	`WHERE t1.unique1 < 1000;`
`90`	`90`	`count \| avg`
`91`	`91`	`-------+--------------------`

`‎src/test/regress/sql/memoize.sql‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,13 +48,13 @@ WHERE t2.unique1 < 1000;`
`48`	`48`	`SELECT explain_memoize('`
`49`	`49`	`SELECT COUNT(*),AVG(t2.unique1) FROM tenk1 t1,`
`50`	`50`	`LATERAL (SELECT t2.unique1 FROM tenk1 t2`
`51`		`- WHERE t1.twenty = t2.unique1ORDER BY 1) t2`
	`51`	`+ WHERE t1.twenty = t2.unique1OFFSET 0) t2`
`52`	`52`	`WHERE t1.unique1 < 1000;', false);`
`53`	`53`
`54`	`54`	`-- And check we get the expected results.`
`55`	`55`	`SELECTCOUNT(*),AVG(t2.unique1)FROM tenk1 t1,`
`56`	`56`	`LATERAL (SELECTt2.unique1FROM tenk1 t2`
`57`		`-WHEREt1.twenty=t2.unique1ORDER BY1) t2`
	`57`	`+WHEREt1.twenty=t2.unique1OFFSET0) t2`
`58`	`58`	`WHEREt1.unique1<1000;`
`59`	`59`
`60`	`60`	`-- Reduce work_mem so that we see some cache evictions`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0765b2f

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/memoize.out‎`

`‎src/test/regress/sql/memoize.sql‎`

0 commit comments