Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit071b2f7

Browse files
committed
Remove obsolete replication settings within TAP tests.
PostgresNode.pm set "max_wal_senders = 5" for replication testing,but this seems to be slightly too low for our current test suite.Slower buildfarm members frequently report "number of requested standbyconnections exceeds max_wal_senders" failures, due to old walsendersnot exiting instantaneously. Usually, the test does not fail overallbecause of automatic walreceiver restart, but sometimes the failurebecomes visible; and in any case such retries slow down the test.That value came in with commit89ac700, but was soon obsoleted byf6d6d29, which raised the built-in default from zero to 10; so thatPostgresNode.pm is actually setting it to less than the conservativebuilt-in default. That seems pretty pointless, so let's remove thespecial setting and let the default prevail, in hopes of makingthe TAP tests more robust.Likewise, the setting "max_replication_slots = 5" is obsolete andcan be removed.While here, reverse-engineer a comment about why we're choosingless-than-default values for some other settings.(Note: before v12, max_wal_senders counted against max_connectionsso that the latter setting also needs some fiddling with.)Back-patch to v10 where the subscription tests were added.It's likely that the older branches aren't pushing the boundariesof max_wal_senders, but I'm disinclined to spend time trying tofigure out exactly when it started to be a problem.Discussion:https://postgr.es/m/723911.1601417626@sss.pgh.pa.us
1 parent3344175 commit071b2f7

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

‎src/test/perl/PostgresNode.pm

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -443,14 +443,13 @@ sub init
443443
{
444444
print$conf"wal_level = replica\n";
445445
}
446-
print$conf"max_wal_senders = 5\n";
447-
print$conf"max_replication_slots = 5\n";
448446
print$conf"wal_keep_segments = 20\n";
449447
print$conf"max_wal_size = 128MB\n";
450-
print$conf"shared_buffers = 1MB\n";
451448
print$conf"wal_log_hints = on\n";
452449
print$conf"hot_standby = on\n";
453-
print$conf"max_connections = 10\n";
450+
# conservative settings to ensure we can run multiple postmasters:
451+
print$conf"shared_buffers = 1MB\n";
452+
print$conf"max_connections = 20\n";
454453
}
455454
else
456455
{

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp