Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit069d33d

Browse files
Emit namespace in the post-copy errmsg
During a VACUUM or CLUSTER command, the initial output emits afully qualified relation path with namespace. The post-actionerrmsg only emitted the relation name however, which may leadto hard to parse output when using multiple jobs with vacuumdbas the output from different jobs may be interleaved. Includethe full path in the post-action errmsg to be consistent withthe initial errmsg.Author: Mike Fiedler <miketheman@gmail.com>Reviewed-by: Corey Huinker <corey.huinker@gmail.com>Discussion:https://postgr.es/m/CAMerE0oz+8G-aORZL_BJcPxnBqewZAvND4bSUysjz+r-oT1BxQ@mail.gmail.com
1 parent4864c8e commit069d33d

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

‎src/backend/access/heap/vacuumlazy.c‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1675,7 +1675,8 @@ lazy_scan_heap(LVRelState *vacrel, VacuumParams *params, bool aggressive)
16751675
appendStringInfo(&buf,_("%s."),pg_rusage_show(&ru0));
16761676

16771677
ereport(elevel,
1678-
(errmsg("table \"%s\": found %lld removable, %lld nonremovable row versions in %u out of %u pages",
1678+
(errmsg("table \"%s.%s\": found %lld removable, %lld nonremovable row versions in %u out of %u pages",
1679+
vacrel->relnamespace,
16791680
vacrel->relname,
16801681
(long long)vacrel->tuples_deleted,
16811682
(long long)vacrel->num_tuples,vacrel->scanned_pages,

‎src/backend/commands/cluster.c‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -776,6 +776,7 @@ copy_table_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,
776776
BlockNumbernum_pages;
777777
intelevel=verbose ?INFO :DEBUG2;
778778
PGRUsageru0;
779+
char*nspname;
779780

780781
pg_rusage_init(&ru0);
781782

@@ -789,6 +790,9 @@ copy_table_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,
789790
else
790791
OldIndex=NULL;
791792

793+
/* Store a copy of the namespace name for logging purposes */
794+
nspname=get_namespace_name(RelationGetNamespace(OldHeap));
795+
792796
/*
793797
* Their tuple descriptors should be exactly alike, but here we only need
794798
* assume that they have the same number of columns.
@@ -887,18 +891,18 @@ copy_table_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,
887891
if (OldIndex!=NULL&& !use_sort)
888892
ereport(elevel,
889893
(errmsg("clustering \"%s.%s\" using index scan on \"%s\"",
890-
get_namespace_name(RelationGetNamespace(OldHeap)),
894+
nspname,
891895
RelationGetRelationName(OldHeap),
892896
RelationGetRelationName(OldIndex))));
893897
elseif (use_sort)
894898
ereport(elevel,
895899
(errmsg("clustering \"%s.%s\" using sequential scan and sort",
896-
get_namespace_name(RelationGetNamespace(OldHeap)),
900+
nspname,
897901
RelationGetRelationName(OldHeap))));
898902
else
899903
ereport(elevel,
900904
(errmsg("vacuuming \"%s.%s\"",
901-
get_namespace_name(RelationGetNamespace(OldHeap)),
905+
nspname,
902906
RelationGetRelationName(OldHeap))));
903907

904908
/*
@@ -923,7 +927,8 @@ copy_table_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,
923927

924928
/* Log what we did */
925929
ereport(elevel,
926-
(errmsg("\"%s\": found %.0f removable, %.0f nonremovable row versions in %u pages",
930+
(errmsg("\"%s.%s\": found %.0f removable, %.0f nonremovable row versions in %u pages",
931+
nspname,
927932
RelationGetRelationName(OldHeap),
928933
tups_vacuumed,num_tuples,
929934
RelationGetNumberOfBlocks(OldHeap)),

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp