Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit067786c

Browse files
Correct obsolete nbtree page deletion comment.
Commitefada2b, which made the nbtree page deletion algorithm morerobust, removed _bt_getstackbuf() calls from _bt_pagedel(). It failedto update a comment that referenced the earlier approach. Update thecomment to explain that the _bt_getstackbuf() page deletion call sitemirrors the only other remaining _bt_getstackbuf() call site, which isreached during page splits.
1 parentb6926de commit067786c

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

‎src/backend/access/nbtree/nbtpage.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,9 +1124,10 @@ _bt_is_page_halfdead(Relation rel, BlockNumber blk)
11241124
*
11251125
* "child" is the leaf page we wish to delete, and "stack" is a search stack
11261126
* leading to it (approximately). Note that we will update the stack
1127-
* entry(s) to reflect current downlink positions --- this is harmless and
1128-
* indeed saves later search effort in _bt_pagedel. The caller should
1129-
* initialize *target and *rightsib to the leaf page and its right sibling.
1127+
* entry(s) to reflect current downlink positions --- this is essentially the
1128+
* same as the corresponding step of splitting, and is not expected to affect
1129+
* caller. The caller should initialize *target and *rightsib to the leaf
1130+
* page and its right sibling.
11301131
*
11311132
* Note: it's OK to release page locks on any internal pages between the leaf
11321133
* and *topparent, because a safe deletion can't become unsafe due to

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp