NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0657181

committed

Improve error reporting for jsonpath .double() method

When jsonpath .double() method detects that numeric or string can't beconverted to double precision, it throws an error. This commit makes theseerrors explicitly express the reason of failure.Discussion:https://postgr.es/m/CAPpHfdtqJtiSXkP7tOXez18NxhLUH_-75bL8%3DOce4Ki%2Bbv7V6Q%40mail.gmail.comAuthor: Alexander KorotkovReviewed-by: Tom LaneBackpatch-through: 12

1 parente91cd95 commit0657181Copy full SHA for 0657181

File tree

3 files changed

-5

lines changed

src
- backend/utils/adt
  - jsonpath_exec.c
- test/regress
  - expected
    - jsonb_jsonpath.out
  - sql
    - jsonb_jsonpath.sql

3 files changed

-5

lines changed

`‎src/backend/utils/adt/jsonpath_exec.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1055,7 +1055,7 @@ executeItemOptUnwrapTarget(JsonPathExecContext cxt, JsonPathItem jsp,`
`1055`	`1055`	`if (have_error)`
`1056`	`1056`	`RETURN_ERROR(ereport(ERROR,`
`1057`	`1057`	`(errcode(ERRCODE_NON_NUMERIC_SQL_JSON_ITEM),`
`1058`		`-errmsg("jsonpath item method .%s()can only be applied to a numeric value",`
	`1058`	`+errmsg("numeric argument ofjsonpath item method .%s()is out of range for type double precision",`
`1059`	`1059`	`jspOperationName(jsp->type)))));`
`1060`	`1060`	`res=jperOk;`
`1061`	`1061`	`}`
`@@ -1076,7 +1076,7 @@ executeItemOptUnwrapTarget(JsonPathExecContext cxt, JsonPathItem jsp,`
`1076`	`1076`	`if (have_error\|\|isinf(val))`
`1077`	`1077`	`RETURN_ERROR(ereport(ERROR,`
`1078`	`1078`	`(errcode(ERRCODE_NON_NUMERIC_SQL_JSON_ITEM),`
`1079`		`-errmsg("jsonpath item method .%s()can only be applied to a numeric value",`
	`1079`	`+errmsg("string argument ofjsonpath item method .%s()is not a valid representation of a double precision number",`
`1080`	`1080`	`jspOperationName(jsp->type)))));`
`1081`	`1081`
`1082`	`1082`	`jb=&jbv;`

`‎src/test/regress/expected/jsonb_jsonpath.out`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1496,7 +1496,9 @@ select jsonb_path_query('"1.23"', '$.double()');`
`1496`	`1496`	`(1 row)`
`1497`	`1497`
`1498`	`1498`	`select jsonb_path_query('"1.23aaa"', '$.double()');`
`1499`		`-ERROR: jsonpath item method .double() can only be applied to a numeric value`
	`1499`	`+ERROR: string argument of jsonpath item method .double() is not a valid representation of a double precision number`
	`1500`	`+select jsonb_path_query('1e1000', '$.double()');`
	`1501`	`+ERROR: numeric argument of jsonpath item method .double() is out of range for type double precision`
`1500`	`1502`	`select jsonb_path_query('"nan"', '$.double()');`
`1501`	`1503`	`jsonb_path_query`
`1502`	`1504`	`------------------`
`@@ -1510,9 +1512,9 @@ select jsonb_path_query('"NaN"', '$.double()');`
`1510`	`1512`	`(1 row)`
`1511`	`1513`
`1512`	`1514`	`select jsonb_path_query('"inf"', '$.double()');`
`1513`		`-ERROR: jsonpath item method .double()can only be applied to a numeric value`
	`1515`	`+ERROR:string argument ofjsonpath item method .double()is not a valid representation of a double precision number`
`1514`	`1516`	`select jsonb_path_query('"-inf"', '$.double()');`
`1515`		`-ERROR: jsonpath item method .double()can only be applied to a numeric value`
	`1517`	`+ERROR:string argument ofjsonpath item method .double()is not a valid representation of a double precision number`
`1516`	`1518`	`select jsonb_path_query('"inf"', '$.double()', silent => true);`
`1517`	`1519`	`jsonb_path_query`
`1518`	`1520`	`------------------`

`‎src/test/regress/sql/jsonb_jsonpath.sql`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -312,6 +312,7 @@ select jsonb_path_query('{}', '$.double()', silent => true);`
`312`	`312`	`select jsonb_path_query('1.23','$.double()');`
`313`	`313`	`select jsonb_path_query('"1.23"','$.double()');`
`314`	`314`	`select jsonb_path_query('"1.23aaa"','$.double()');`
	`315`	`+select jsonb_path_query('1e1000','$.double()');`
`315`	`316`	`select jsonb_path_query('"nan"','$.double()');`
`316`	`317`	`select jsonb_path_query('"NaN"','$.double()');`
`317`	`318`	`select jsonb_path_query('"inf"','$.double()');`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0657181

File tree

3 files changed

3 files changed

`‎src/backend/utils/adt/jsonpath_exec.c`

`‎src/test/regress/expected/jsonb_jsonpath.out`

`‎src/test/regress/sql/jsonb_jsonpath.sql`

0 commit comments