NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit062824e

committed

Ensure commands in extension scripts see the results of preceding DDL.

Due to a missing CommandCounterIncrement() call, parsing of a non-utilitycommand in an extension script would not see the effects of the immediatelypreceding DDL command, unless that command's execution ends withCommandCounterIncrement() internally ... which some do but many don't.Report by Philippe Beaudoin, diagnosis by Julien Rouhaud.Rather remarkably, this bug has evaded detection since extensions wereinvented, so back-patch to all supported branches.Discussion:https://postgr.es/m/2cf7941e-4e41-7714-3de8-37b1a8f74dff@free.fr

1 parentdc93caf commit062824eCopy full SHA for 062824e

File tree

1 file changed

-0

lines changed

src/backend/commands
- extension.c

1 file changed

-0

lines changed

`‎src/backend/commands/extension.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -710,6 +710,9 @@ execute_sql_string(const char sql, const char filename)`
`710`	`710`	`List*stmt_list;`
`711`	`711`	`ListCell*lc2;`
`712`	`712`
	`713`	`+/* Be sure parser can see any DDL done so far */`
	`714`	`+CommandCounterIncrement();`
	`715`	`+`
`713`	`716`	`stmt_list=pg_analyze_and_rewrite(parsetree,`
`714`	`717`	`sql,`
`715`	`718`	`NULL,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit062824e

File tree

1 file changed

1 file changed

`‎src/backend/commands/extension.c`

0 commit comments