Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit059de3c

Browse files
committed
Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings view.
set_config_option() bails out early if it detects that the option tobe set is PGC_BACKEND or PGC_SU_BACKEND class and we're reading theconfig file in a postmaster child; we don't want to apply any newvalue in such a case. That's fine as far as it goes, but it failsto consider the requirements of the pg_file_settings view: for that,we need to check validity of the value even though we have nointention to apply it. Because we didn't, even very silly valuesfor affected GUCs would be reported as valid by the view. Thereare only half a dozen such GUCs, which perhaps explains why thisgot overlooked for so long.Fix by continuing when changeVal is false; this parallels the logicin some other early-exit paths.Also, the check added by commit924bcf4 to prevent GUC changes inparallel workers seems a few bricks shy of a load: it's evidentlyassuming that ereport(elevel, ...) won't return. Make sure webail out if it does. The lack of trouble reports suggests thatthis is only a latent bug, i.e. parallel workers don't actuallyreach here with elevel < ERROR. (Per the code coverage report,we never reach here at all in the regression suite.) But we clearlydon't want to risk proceeding if that does happen.Per report from Rıdvan Korkmaz. These are ancient bugs, so back-patchto all supported branches.Discussion:https://postgr.es/m/2089235.1703617353@sss.pgh.pa.us
1 parenta46972e commit059de3c

File tree

1 file changed

+8
-1
lines changed
  • src/backend/utils/misc

1 file changed

+8
-1
lines changed

‎src/backend/utils/misc/guc.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3412,9 +3412,12 @@ set_config_with_handle(const char *name, config_handle *handle,
34123412
* Other changes might need to affect other workers, so forbid them.
34133413
*/
34143414
if (IsInParallelMode()&&changeVal&&action!=GUC_ACTION_SAVE)
3415+
{
34153416
ereport(elevel,
34163417
(errcode(ERRCODE_INVALID_TRANSACTION_STATE),
34173418
errmsg("cannot set parameters during a parallel operation")));
3419+
return-1;
3420+
}
34183421

34193422
/* if handle is specified, no need to look up option */
34203423
if (!handle)
@@ -3515,6 +3518,10 @@ set_config_with_handle(const char *name, config_handle *handle,
35153518
* backends. This is a tad klugy, but necessary because we
35163519
* don't re-read the config file during backend start.
35173520
*
3521+
* However, if changeVal is false then plow ahead anyway since
3522+
* we are trying to find out if the value is potentially good,
3523+
* not actually use it.
3524+
*
35183525
* In EXEC_BACKEND builds, this works differently: we load all
35193526
* non-default settings from the CONFIG_EXEC_PARAMS file
35203527
* during backend start. In that case we must accept
@@ -3525,7 +3532,7 @@ set_config_with_handle(const char *name, config_handle *handle,
35253532
* started it. is_reload will be true when either situation
35263533
* applies.
35273534
*/
3528-
if (IsUnderPostmaster&& !is_reload)
3535+
if (IsUnderPostmaster&&changeVal&&!is_reload)
35293536
return-1;
35303537
}
35313538
elseif (context!=PGC_POSTMASTER&&

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp