NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit055891f

committed

Make sure to run pg_isready on correct port

The current code can have pg_isready unexpectedly succeed if there is aserver running on the default port. To avoid this we delay running thetest until after a node has been created but before it starts, and thenuse that node's port, so we are fairly sure there is nothing running onthe port.Backpatch to all live branches.

1 parenta8458f5 commit055891fCopy full SHA for 055891f

File tree

1 file changed

-2

lines changed

src/bin/scripts/t
- 080_pg_isready.pl

1 file changed

-2

lines changed

`‎src/bin/scripts/t/080_pg_isready.pl`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,10 +12,11 @@`
`12`	`12`	`program_version_ok('pg_isready');`
`13`	`13`	`program_options_handling_ok('pg_isready');`
`14`	`14`
`15`		`-command_fails(['pg_isready'],'fails with no server running');`
`16`		`-`
`17`	`15`	`my$node = PostgreSQL::Test::Cluster->new('main');`
`18`	`16`	`$node->init;`
	`17`	`+`
	`18`	`+$node->command_fails(['pg_isready'],'fails with no server running');`
	`19`	`+`
`19`	`20`	`$node->start;`
`20`	`21`
`21`	`22`	`$node->command_ok(`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit055891f

File tree

1 file changed

1 file changed

`‎src/bin/scripts/t/080_pg_isready.pl`

0 commit comments