NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0539593

committed

pg_stat_statements forgot to let previous occupant of hook get control too.

pgss_post_parse_analyze() neglected to pass the call on to any earlieroccupant of the post_parse_analyze_hook. There are no other users of thathook in contrib/, and most likely none in the wild either, so this isprobably just a latent bug. But it's a bug nonetheless, so back-patchto 9.2 where this code was introduced.

1 parent98876f0 commit0539593Copy full SHA for 0539593

File tree

1 file changed

-0

lines changed

contrib/pg_stat_statements
- pg_stat_statements.c

1 file changed

-0

lines changed

`‎contrib/pg_stat_statements/pg_stat_statements.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -614,6 +614,9 @@ pgss_post_parse_analyze(ParseState pstate, Query query)`
`614`	`614`	`{`
`615`	`615`	`pgssJumbleStatejstate;`
`616`	`616`
	`617`	`+if (prev_post_parse_analyze_hook)`
	`618`	`+prev_post_parse_analyze_hook(pstate,query);`
	`619`	`+`
`617`	`620`	`/* Assert we didn't do this already */`
`618`	`621`	`Assert(query->queryId==0);`
`619`	`622`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0539593

File tree

1 file changed

1 file changed

`‎contrib/pg_stat_statements/pg_stat_statements.c`

0 commit comments