forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit0518ece
committed
Adjust HeapTupleSatisfies* routines to take a HeapTuple.
Previously, these functions took a HeapTupleHeader, but upcomingpatches for logical replication will introduce new a new snapshottype under which the tuple's TID will be used to lookup (CMIN, CMAX)for visibility determination purposes. This makes that informationavailable. Code churn is minimal since HeapTupleSatisfiesVisibilitytook the HeapTuple anyway, and deferenced it before calling thesatisfies function.Independently of logical replication, this allows t_tableOid andt_self to be cross-checked via assertions in tqual.c. This seemslike a useful way to make sure that all callers are setting thesevalues properly, which has been previously put forward asdesirable.Andres Freund, reviewed by Álvaro Herrera1 parent0aeb5ae commit0518ece
File tree
12 files changed
+91
-38
lines changed- contrib/pgrowlocks
- src
- backend
- access/heap
- catalog
- commands
- executor
- storage/lmgr
- utils/time
- include/utils
12 files changed
+91
-38
lines changedLines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
131 | 131 |
| |
132 | 132 |
| |
133 | 133 |
| |
134 |
| - | |
| 134 | + | |
135 | 135 |
| |
136 | 136 |
| |
137 | 137 |
| |
|
Lines changed: 8 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
387 | 387 |
| |
388 | 388 |
| |
389 | 389 |
| |
| 390 | + | |
390 | 391 |
| |
391 | 392 |
| |
392 | 393 |
| |
| |||
1715 | 1716 |
| |
1716 | 1717 |
| |
1717 | 1718 |
| |
1718 |
| - | |
| 1719 | + | |
1719 | 1720 |
| |
1720 | 1721 |
| |
1721 | 1722 |
| |
| |||
1763 | 1764 |
| |
1764 | 1765 |
| |
1765 | 1766 |
| |
1766 |
| - | |
| 1767 | + | |
1767 | 1768 |
| |
1768 | 1769 |
| |
1769 | 1770 |
| |
| |||
1893 | 1894 |
| |
1894 | 1895 |
| |
1895 | 1896 |
| |
| 1897 | + | |
1896 | 1898 |
| |
1897 | 1899 |
| |
1898 | 1900 |
| |
| |||
2591 | 2593 |
| |
2592 | 2594 |
| |
2593 | 2595 |
| |
| 2596 | + | |
2594 | 2597 |
| |
2595 | 2598 |
| |
2596 | 2599 |
| |
2597 | 2600 |
| |
2598 | 2601 |
| |
2599 |
| - | |
| 2602 | + | |
2600 | 2603 |
| |
2601 | 2604 |
| |
2602 | 2605 |
| |
| |||
3070 | 3073 |
| |
3071 | 3074 |
| |
3072 | 3075 |
| |
3073 |
| - | |
| 3076 | + | |
3074 | 3077 |
| |
3075 | 3078 |
| |
3076 | 3079 |
| |
| |||
3941 | 3944 |
| |
3942 | 3945 |
| |
3943 | 3946 |
| |
3944 |
| - | |
| 3947 | + | |
3945 | 3948 |
| |
3946 | 3949 |
| |
3947 | 3950 |
| |
|
Lines changed: 15 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
339 | 339 |
| |
340 | 340 |
| |
341 | 341 |
| |
| 342 | + | |
| 343 | + | |
| 344 | + | |
342 | 345 |
| |
343 | 346 |
| |
344 | 347 |
| |
| |||
348 | 351 |
| |
349 | 352 |
| |
350 | 353 |
| |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
351 | 360 |
| |
352 | 361 |
| |
353 | 362 |
| |
| |||
368 | 377 |
| |
369 | 378 |
| |
370 | 379 |
| |
371 |
| - | |
| 380 | + | |
372 | 381 |
| |
373 | 382 |
| |
374 | 383 |
| |
| |||
431 | 440 |
| |
432 | 441 |
| |
433 | 442 |
| |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
434 | 447 |
| |
435 | 448 |
| |
436 | 449 |
| |
| |||
448 | 461 |
| |
449 | 462 |
| |
450 | 463 |
| |
451 |
| - | |
| 464 | + | |
452 | 465 |
| |
453 | 466 |
| |
454 | 467 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2251 | 2251 |
| |
2252 | 2252 |
| |
2253 | 2253 |
| |
2254 |
| - | |
| 2254 | + | |
2255 | 2255 |
| |
2256 | 2256 |
| |
2257 | 2257 |
| |
|
Lines changed: 2 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1138 | 1138 |
| |
1139 | 1139 |
| |
1140 | 1140 |
| |
| 1141 | + | |
1141 | 1142 |
| |
1142 | 1143 |
| |
1143 | 1144 |
| |
1144 |
| - | |
| 1145 | + | |
1145 | 1146 |
| |
1146 | 1147 |
| |
1147 | 1148 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
979 | 979 |
| |
980 | 980 |
| |
981 | 981 |
| |
982 |
| - | |
| 982 | + | |
983 | 983 |
| |
984 | 984 |
| |
985 | 985 |
| |
|
Lines changed: 8 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
151 | 151 |
| |
152 | 152 |
| |
153 | 153 |
| |
154 |
| - | |
| 154 | + | |
155 | 155 |
| |
156 | 156 |
| |
157 | 157 |
| |
| |||
756 | 756 |
| |
757 | 757 |
| |
758 | 758 |
| |
| 759 | + | |
759 | 760 |
| |
760 | 761 |
| |
761 | 762 |
| |
762 |
| - | |
| 763 | + | |
763 | 764 |
| |
764 | 765 |
| |
765 | 766 |
| |
| |||
1168 | 1169 |
| |
1169 | 1170 |
| |
1170 | 1171 |
| |
1171 |
| - | |
| 1172 | + | |
1172 | 1173 |
| |
1173 | 1174 |
| |
1174 | 1175 |
| |
| |||
1676 | 1677 |
| |
1677 | 1678 |
| |
1678 | 1679 |
| |
1679 |
| - | |
| 1680 | + | |
1680 | 1681 |
| |
1681 | 1682 |
| |
1682 | 1683 |
| |
| |||
1718 | 1719 |
| |
1719 | 1720 |
| |
1720 | 1721 |
| |
| 1722 | + | |
| 1723 | + | |
1721 | 1724 |
| |
1722 |
| - | |
| 1725 | + | |
1723 | 1726 |
| |
1724 | 1727 |
| |
1725 | 1728 |
| |
|
Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
258 | 258 |
| |
259 | 259 |
| |
260 | 260 |
| |
| 261 | + | |
261 | 262 |
| |
262 | 263 |
| |
263 | 264 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3895 | 3895 |
| |
3896 | 3896 |
| |
3897 | 3897 |
| |
3898 |
| - | |
| 3898 | + | |
3899 | 3899 |
| |
3900 | 3900 |
| |
3901 | 3901 |
| |
|
Lines changed: 41 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
163 | 163 |
| |
164 | 164 |
| |
165 | 165 |
| |
166 |
| - | |
| 166 | + | |
167 | 167 |
| |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
168 | 172 |
| |
169 | 173 |
| |
170 | 174 |
| |
| |||
351 | 355 |
| |
352 | 356 |
| |
353 | 357 |
| |
354 |
| - | |
| 358 | + | |
355 | 359 |
| |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
356 | 364 |
| |
357 | 365 |
| |
358 | 366 |
| |
| |||
526 | 534 |
| |
527 | 535 |
| |
528 | 536 |
| |
529 |
| - | |
| 537 | + | |
530 | 538 |
| |
531 | 539 |
| |
532 | 540 |
| |
| |||
546 | 554 |
| |
547 | 555 |
| |
548 | 556 |
| |
549 |
| - | |
| 557 | + | |
550 | 558 |
| |
551 | 559 |
| |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
552 | 564 |
| |
553 | 565 |
| |
554 | 566 |
| |
| |||
627 | 639 |
| |
628 | 640 |
| |
629 | 641 |
| |
630 |
| - | |
| 642 | + | |
631 | 643 |
| |
632 | 644 |
| |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
633 | 649 |
| |
634 | 650 |
| |
635 | 651 |
| |
| |||
849 | 865 |
| |
850 | 866 |
| |
851 | 867 |
| |
852 |
| - | |
| 868 | + | |
853 | 869 |
| |
854 | 870 |
| |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
855 | 875 |
| |
856 | 876 |
| |
857 | 877 |
| |
| |||
1040 | 1060 |
| |
1041 | 1061 |
| |
1042 | 1062 |
| |
1043 |
| - | |
| 1063 | + | |
1044 | 1064 |
| |
1045 | 1065 |
| |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
1046 | 1070 |
| |
1047 | 1071 |
| |
1048 | 1072 |
| |
| |||
1233 | 1257 |
| |
1234 | 1258 |
| |
1235 | 1259 |
| |
1236 |
| - | |
| 1260 | + | |
1237 | 1261 |
| |
1238 | 1262 |
| |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
1239 | 1267 |
| |
1240 | 1268 |
| |
1241 | 1269 |
| |
| |||
1466 | 1494 |
| |
1467 | 1495 |
| |
1468 | 1496 |
| |
1469 |
| - | |
| 1497 | + | |
1470 | 1498 |
| |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
1471 | 1503 |
| |
1472 | 1504 |
| |
1473 | 1505 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
27 | 27 |
| |
28 | 28 |
| |
29 | 29 |
| |
30 |
| - | |
31 |
| - | |
| 30 | + | |
| 31 | + | |
32 | 32 |
| |
33 | 33 |
| |
34 | 34 |
| |
|
0 commit comments
Comments
(0)