Commit04bec89

committed

initdb: Change default to using data checksums.

Checksums are now on by default. They can be disabled by thepreviously added option --no-data-checksums.Author: Greg Sabino Mullane <greg@turnstep.com>Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>Reviewed-by: Peter Eisentraut <peter@eisentraut.org>Reviewed-by: Daniel Gustafsson <daniel@yesql.se>Discussion:https://www.postgresql.org/message-id/flat/CAKAnmmKwiMHik5AHmBEdf5vqzbOBbcwEPHo4-PioWeAbzwcTOQ@mail.gmail.com

1 parent6784655 commit04bec89Copy full SHA for 04bec89

File tree

+21

-14

lines changed

+21

-14

lines changed

Lines changed: 10 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -265,8 +265,14 @@ PostgreSQL documentation`
`265`	`265`	`<term><option>--data-checksums</option></term>`
`266`	`266`	`<listitem>`
`267`	`267`	`<para>`
`268`		`- Use checksums on data pages to help detect corruption by the`
`269`		`- I/O system that would otherwise be silent. Enabling checksums`
	`268`	`+ Use checksums on data pages to help detect corruption by the I/O`
	`269`	`+ system that would otherwise be silent. This is enabled by default;`
	`270`	`+ use <xref linkend="app-initdb-no-data-checksums"/> to disable`
	`271`	`+ checksums.`
	`272`	`+ </para>`
	`273`	`+`
	`274`	`+ <para>`
	`275`	`+ Enabling checksums`
`270`	`276`	`might incur a small performance penalty. If set, checksums`
`271`	`277`	`are calculated for all objects, in all databases. All checksum`
`272`	`278`	`failures will be reported in the`
`@@ -343,12 +349,11 @@ PostgreSQL documentation`
`343`	`349`	`</listitem>`
`344`	`350`	`</varlistentry>`
`345`	`351`
`346`		`- <varlistentry id="app-initdb-no-data-checksums" xreflabel="no data checksums">`
	`352`	`+ <varlistentry id="app-initdb-no-data-checksums">`
`347`	`353`	`<term><option>--no-data-checksums</option></term>`
`348`	`354`	`<listitem>`
`349`	`355`	`<para>`
`350`		`- Do not enable data checksums. This can be used to override a`
`351`		`- <option>--data-checksums</option> option.`
	`356`	`+ Do not enable data checksums.`
`352`	`357`	`</para>`
`353`	`358`	`</listitem>`
`354`	`359`	`</varlistentry>`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ static bool noinstructions = false;`
`164`	`164`	`staticbooldo_sync= true;`
`165`	`165`	`staticboolsync_only= false;`
`166`	`166`	`staticboolshow_setting= false;`
`167`		`-staticbooldata_checksums=false;`
	`167`	`+staticbooldata_checksums=true;`
`168`	`168`	`staticchar*xlog_dir=NULL;`
`169`	`169`	`staticintwal_segment_size_mb= (DEFAULT_XLOG_SEG_SIZE) / (1024*1024);`
`170`	`170`	`staticDataDirSyncMethodsync_method=DATA_DIR_SYNC_METHOD_FSYNC;`

Lines changed: 10 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,16 +69,11 @@`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`
`72`		`-# Control file should tell that data checksums aredisabled by default.`
	`72`	`+# Control file should tell that data checksums areenabled by default.`
`73`	`73`	`command_like(`
`74`	`74`	`['pg_controldata',$datadir ],`
`75`		`-qr/Data page checksum version:.*0/,`
`76`		`-'checksums are disabled in control file');`
`77`		`-# pg_checksums fails with checksums disabled by default. This is`
`78`		`-# not part of the tests included in pg_checksums to save from`
`79`		`-# the creation of an extra instance.`
`80`		`-command_fails(['pg_checksums','-D',$datadir ],`
`81`		`-"pg_checksums fails with data checksum disabled");`
	`75`	`+qr/Data page checksum version:.*1/,`
	`76`	`+'checksums are enabled in control file');`
`82`	`77`
`83`	`78`	`command_ok(['initdb','-S',$datadir ],'sync only');`
`84`	`79`	`command_fails(['initdb',$datadir ],'existing data directory');`
`@@ -280,4 +275,11 @@`
`280`	`275`	`qr/Data page checksum version:.*0/,`
`281`	`276`	`'checksums are disabled in control file');`
`282`	`277`
	`278`	`+# pg_checksums fails with checksums disabled. This is`
	`279`	`+# not part of the tests included in pg_checksums to save from`
	`280`	`+# the creation of an extra instance.`
	`281`	`+command_fails(`
	`282`	`+['pg_checksums','-D',$datadir_nochecksums ],`
	`283`	`+"pg_checksums fails with data checksum disabled");`
	`284`	`+`
`283`	`285`	`done_testing();`

Comments

(0)