NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit04ae11f

committed

Remove bogus code to apply PathTargets to partial paths.

The partial paths that get modified may already have been used aspart of a GatherPath which appears in the path list, so modifyingthem is not a good idea at this stage - especially because thiscode has no check that the PathTarget is in fact parallel-safe.When partial aggregation is being performed, this is actuallyharmless because we'll end up replacing the pathtargets here withthe correct ones within create_grouping_paths(). But if we've gota query tree containing only scan/join operations then this canresult in incorrectly pushing down parallel-restricted targetlist entries. If those are, for example, references to subqueries,that can crash the server; but it's wrong in any event.Amit Kapila

1 parentcac8321 commit04ae11fCopy full SHA for 04ae11f

File tree

1 file changed

-13

lines changed

src/backend/optimizer/plan
- planner.c

1 file changed

-13

lines changed

`‎src/backend/optimizer/plan/planner.c`

Lines changed: 0 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -1758,19 +1758,6 @@ grouping_planner(PlannerInfo *root, bool inheritance_update,`
`1758`	`1758`	`}`
`1759`	`1759`	`}`
`1760`	`1760`
`1761`		`-/*`
`1762`		`- * Likewise for any partial paths, although this case is simpler, since`
`1763`		`- * we don't track the cheapest path.`
`1764`		`- */`
`1765`		`-foreach(lc,current_rel->partial_pathlist)`
`1766`		`-{`
`1767`		`-Pathsubpath= (Path)lfirst(lc);`
`1768`		`-`
`1769`		`-Assert(subpath->param_info==NULL);`
`1770`		`-lfirst(lc)=apply_projection_to_path(root,current_rel,`
`1771`		`-subpath,scanjoin_target);`
`1772`		`-}`
`1773`		`-`
`1774`	`1761`	`/*`
`1775`	`1762`	`* Save the various upper-rel PathTargets we just computed into`
`1776`	`1763`	`* root->upper_targets[]. The core code doesn't use this, but it`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit04ae11f

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/planner.c`

0 commit comments