NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0424128

committed

autovacuum: Improve wording in a couple places

A few strings (one WARNING and some memory context names) in theautovacuum code were written in a world where "worker" had no otherpossible meaning than "autovacuum worker", but that's long time gone.Be more specific about it.Also, change the WARNING from elog() to ereport(), to add translability.Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>Reviewed-by: Nathan Bossart <bossartn@amazon.com>Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>Reviewed-by: Dilip Kumar <dilipbalaut@gmail.com>Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>Discussion:https://postgr.es/m/CALj2ACX2UHp76dqdoZq92a7v4APFuV5wJQ+AUrb+2HURrKN=NQ@mail.gmail.com

1 parent6738554 commit0424128Copy full SHA for 0424128

File tree

1 file changed

-6

lines changed

src/backend/postmaster
- autovacuum.c

1 file changed

-6

lines changed

`‎src/backend/postmaster/autovacuum.c`

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -754,7 +754,8 @@ AutoVacLauncherMain(int argc, char *argv[])`
`754`	`754`	`dlist_push_head(&AutoVacuumShmem->av_freeWorkers,`
`755`	`755`	`&worker->wi_links);`
`756`	`756`	`AutoVacuumShmem->av_startingWorker=NULL;`
`757`		`-elog(WARNING,"worker took too long to start; canceled");`
	`757`	`+ereport(WARNING,`
	`758`	`+errmsg("autovacuum worker took too long to start; canceled"));`
`758`	`759`	`}`
`759`	`760`	`}`
`760`	`761`	`else`
`@@ -966,10 +967,10 @@ rebuild_database_list(Oid newdb)`
`966`	`967`	`autovac_refresh_stats();`
`967`	`968`
`968`	`969`	`newcxt=AllocSetContextCreate(AutovacMemCxt,`
`969`		`-"AV dblist",`
	`970`	`+"Autovacuum database list",`
`970`	`971`	`ALLOCSET_DEFAULT_SIZES);`
`971`	`972`	`tmpcxt=AllocSetContextCreate(newcxt,`
`972`		`-"tmp AV dblist",`
	`973`	`+"Autovacuum database list (tmp)",`
`973`	`974`	`ALLOCSET_DEFAULT_SIZES);`
`974`	`975`	`oldcxt=MemoryContextSwitchTo(tmpcxt);`
`975`	`976`
`@@ -992,7 +993,7 @@ rebuild_database_list(Oid newdb)`
`992`	`993`	`hctl.keysize=sizeof(Oid);`
`993`	`994`	`hctl.entrysize=sizeof(avl_dbase);`
`994`	`995`	`hctl.hcxt=tmpcxt;`
`995`		`-dbhash=hash_create("db hash",20,&hctl,/* magic number here FIXME */`
	`996`	`+dbhash=hash_create("autovacuumdb hash",20,&hctl,/* magic number here FIXME */`
`996`	`997`	`HASH_ELEM \|HASH_BLOBS \|HASH_CONTEXT);`
`997`	`998`
`998`	`999`	`/* start by inserting the new database */`
`@@ -1179,7 +1180,7 @@ do_start_worker(void)`
`1179`	`1180`	`* allocated for the database list.`
`1180`	`1181`	`*/`
`1181`	`1182`	`tmpcxt=AllocSetContextCreate(CurrentMemoryContext,`
`1182`		`-"Startworker tmp cxt",`
	`1183`	`+"Autovacuum startworker(tmp)",`
`1183`	`1184`	`ALLOCSET_DEFAULT_SIZES);`
`1184`	`1185`	`oldcxt=MemoryContextSwitchTo(tmpcxt);`
`1185`	`1186`
`@@ -1981,7 +1982,7 @@ do_autovacuum(void)`
`1981`	`1982`	`* relations to vacuum/analyze across transactions.`
`1982`	`1983`	`*/`
`1983`	`1984`	`AutovacMemCxt=AllocSetContextCreate(TopMemoryContext,`
`1984`		`-"AV worker",`
	`1985`	`+"Autovacuum worker",`
`1985`	`1986`	`ALLOCSET_DEFAULT_SIZES);`
`1986`	`1987`	`MemoryContextSwitchTo(AutovacMemCxt);`
`1987`	`1988`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0424128

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/autovacuum.c`

0 commit comments