NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit038a2ed

committed

Stabilize regression test result.

If random() returns a result sufficiently close to zero, float8outswitches to scientific notation, breaking this test case's expectationthat the output should look like '0.xxxxxxxxx'. Casting to numericshould fix that. Per buildfarm member pogona.Discussion:https://postgr.es/m/20180324212502.wt4serghfidge2on@alap3.anarazel.de

1 parentda61695 commit038a2edCopy full SHA for 038a2ed

File tree

2 files changed

-2

lines changed

src/test/regress
- expected
  - create_procedure.out
- sql
  - create_procedure.sql

2 files changed

-2

lines changed

`‎src/test/regress/expected/create_procedure.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ LINE 1: SELECT ptest1('x');`
`22`	`22`	`HINT: To call a procedure, use CALL.`
`23`	`23`	`CALL ptest1('a'); -- ok`
`24`	`24`	`CALL ptest1('xy' \|\| 'zzy'); -- ok, constant-folded arg`
`25`		`-CALL ptest1(substring(random()::text, 1, 1)); -- ok, volatile arg`
	`25`	`+CALL ptest1(substring(random()::numeric(20,15)::text, 1, 1)); -- ok, volatile arg`
`26`	`26`	`\df ptest1`
`27`	`27`	`List of functions`
`28`	`28`	`Schema \| Name \| Result data type \| Argument data types \| Type`

`‎src/test/regress/sql/create_procedure.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ $$;`
`14`	`14`	`SELECT ptest1('x');-- error`
`15`	`15`	`CALL ptest1('a');-- ok`
`16`	`16`	`CALL ptest1('xy'\|\|'zzy');-- ok, constant-folded arg`
`17`		`-CALL ptest1(substring(random()::text,1,1));-- ok, volatile arg`
	`17`	`+CALL ptest1(substring(random()::numeric(20,15)::text,1,1));-- ok, volatile arg`
`18`	`18`
`19`	`19`	`\df ptest1`
`20`	`20`	`SELECT pg_get_functiondef('ptest1'::regproc);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit038a2ed

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/create_procedure.out`

`‎src/test/regress/sql/create_procedure.sql`

0 commit comments