NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit038512f

committed

Fix version comparison in Version.pm

Version strings with unequal numbers of parts were being comparedincorrectly. We cure this by treating a missing part in the shorterversion as 0.per complaint from Jehan-Guillaume de Rorthais, but the fix is mine, nothis.Discussion:https://postgr.es/m/20220628225325.53d97b8d@karstBackpatch to release 14 where this code was introduced.

1 parent32d5a49 commit038512fCopy full SHA for 038512f

File tree

1 file changed

-3

lines changed

src/test/perl
- PostgresVersion.pm

1 file changed

-3

lines changed

`‎src/test/perl/PostgresVersion.pm`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -120,9 +120,12 @@ sub _version_cmp`
`120`	`120`
`121`	`121`	`for (my$idx = 0;;$idx++)`
`122`	`122`	`{`
`123`		`-return 0unless (defined$an->[$idx] &&defined$bn->[$idx]);`
`124`		`-return$an->[$idx]<=>$bn->[$idx]`
`125`		`-if ($an->[$idx]<=>$bn->[$idx]);`
	`123`	`+return 0`
	`124`	`+if ($idx >=@$an &&$idx >=@$bn);`
	`125`	`+# treat a missing number as 0`
	`126`	`+my ($anum,$bnum) = ($an->[$idx] \|\| 0,$bn->[$idx] \|\| 0);`
	`127`	`+return$anum<=>$bnum`
	`128`	`+if ($anum<=>$bnum);`
`126`	`129`	`}`
`127`	`130`	`}`
`128`	`131`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit038512f

File tree

1 file changed

1 file changed

`‎src/test/perl/PostgresVersion.pm`

0 commit comments