NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit03838b8

committed

Fix pg_upgrade to handle event triggers in extensions correctly.

pg_dump with --binary-upgrade must emit ALTER EXTENSION ADD commandsfor all objects that are members of extensions. It forgot to do so forevent triggers, as per bug #15310 from Nick Barnes. Back-patch to 9.3where event triggers were introduced.Haribabu KommiDiscussion:https://postgr.es/m/153360083872.1395.4593932457718151600@wrigleys.postgresql.org

1 parent5b5ed47 commit03838b8Copy full SHA for 03838b8

File tree

1 file changed

-0

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-0

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -17302,6 +17302,10 @@ dumpEventTrigger(Archive fout, EventTriggerInfo evtinfo)`
`17302`	`17302`	`appendPQExpBuffer(delqry, "DROP EVENT TRIGGER %s;\n",`
`17303`	`17303`	`qevtname);`
`17304`	`17304`
	`17305`	`+if (dopt->binary_upgrade)`
	`17306`	`+binary_upgrade_extension_member(query, &evtinfo->dobj,`
	`17307`	`+"EVENT TRIGGER", qevtname, NULL);`
	`17308`	`+`
`17305`	`17309`	`if (evtinfo->dobj.dump & DUMP_COMPONENT_DEFINITION)`
`17306`	`17310`	`ArchiveEntry(fout, evtinfo->dobj.catId, evtinfo->dobj.dumpId,`
`17307`	`17311`	`evtinfo->dobj.name, NULL, NULL,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit03838b8

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments