NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit036297c

committed

Pack struct ParsedWord more tightly.

In a 64-bit build there's an awful lot of useless pad space inParsedWords. Since we may allocate large arrays of these,it's worth some effort to reduce their size.Here we reduce the alen field from uint32 to uint16, and then re-orderthe fields to avoid unnecessary padding. alen is only used toremember the allocated size of the apos[] array, which is not allowedto exceed MAXNUMPOS (256) elements, so uint16 is plenty of space forit. That gets us from 40 bytes to 24 on 64-bit builds, and from 20bytes to 16 on 32-bit builds.Per discussion of bug #18080. Unfortunately this is an ABI breakso we can't back-patch.Discussion:https://postgr.es/m/1146921.1695411070@sss.pgh.pa.us

1 parentcf1c650 commit036297cCopy full SHA for 036297c

File tree

1 file changed

-3

lines changed

src/include/tsearch
- ts_utils.h

1 file changed

-3

lines changed

`‎src/include/tsearch/ts_utils.h`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,22 +81,22 @@ extern void pushOperator(TSQueryParserState state, int8 oper, int16 distance);`
`81`	`81`	`*/`
`82`	`82`	`typedefstruct`
`83`	`83`	`{`
	`84`	`+uint16flags;/* currently, only TSL_PREFIX */`
`84`	`85`	`uint16len;`
`85`	`86`	`uint16nvariant;`
	`87`	`+uint16alen;`
`86`	`88`	`union`
`87`	`89`	`{`
`88`	`90`	`uint16pos;`
`89`	`91`
`90`	`92`	`/*`
`91`	`93`	`* When apos array is used, apos[0] is the number of elements in the`
`92`	`94`	`* array (excluding apos[0]), and alen is the allocated size of the`
`93`		`- * array.`
	`95`	`+ * array. We do not allow more than MAXNUMPOS array elements.`
`94`	`96`	`*/`
`95`	`97`	`uint16*apos;`
`96`	`98`	`}pos;`
`97`		`-uint16flags;/* currently, only TSL_PREFIX */`
`98`	`99`	`char*word;`
`99`		`-uint32alen;`
`100`	`100`	`}ParsedWord;`
`101`	`101`
`102`	`102`	`typedefstruct`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit036297c

File tree

1 file changed

1 file changed

`‎src/include/tsearch/ts_utils.h`

0 commit comments