forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit03561a6
committed
Fix unnecessary use of moving-aggregate mode with non-moving frame.
When a plain aggregate is used as a window function, and the windowframe start is specified as UNBOUNDED PRECEDING, the frame's headcannot move so we do not need to use moving-aggregate mode. The checkfor that was put into initialize_peragg(), failing to notice thatExecInitWindowAgg() calls that function before it's filled inwinstate->frameOptions. Since makeNode() would have zeroed the field,this didn't provoke uninitialized-value complaints, nor would theerroneous decision have resulted in more than a little inefficiency.Still, it's wrong, so move the initialization ofwinstate->frameOptions earlier to make it work properly.While here, also fix a thinko in a comment. Both errors crept in incommita9d9acb which introduced the moving-aggregate mode.Spotted by Vallimaharajan G. Back-patch to all supported branches.Discussion:https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com1 parentb48eda4 commit03561a6
1 file changed
+4
-4
lines changedLines changed: 4 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2397 | 2397 |
| |
2398 | 2398 |
| |
2399 | 2399 |
| |
| 2400 | + | |
| 2401 | + | |
| 2402 | + | |
2400 | 2403 |
| |
2401 | 2404 |
| |
2402 | 2405 |
| |
| |||
2647 | 2650 |
| |
2648 | 2651 |
| |
2649 | 2652 |
| |
2650 |
| - | |
2651 |
| - | |
2652 |
| - | |
2653 | 2653 |
| |
2654 | 2654 |
| |
2655 | 2655 |
| |
| |||
2800 | 2800 |
| |
2801 | 2801 |
| |
2802 | 2802 |
| |
2803 |
| - | |
| 2803 | + | |
2804 | 2804 |
| |
2805 | 2805 |
| |
2806 | 2806 |
| |
|
0 commit comments
Comments
(0)