NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit02a75f8

committed

Add missing error check in pgcrypto/crypt-md5.c.

In theory, the second px_find_digest call in px_crypt_md5 could faileven though the first one succeeded, since resource allocation isrequired. Don't skip testing for a failure. (If one did happen,the likely result would be a crash rather than clean recovery froman OOM failure.)The code's been like this all along, so back-patch to all supportedbranches.Daniel GustafssonDiscussion:https://postgr.es/m/AA8D6FE9-4AB2-41B4-98CB-AE64BA668C03@yesql.se

1 parentbc49f87 commit02a75f8Copy full SHA for 02a75f8

File tree

1 file changed

-1

lines changed

contrib/pgcrypto
- crypt-md5.c

1 file changed

-1

lines changed

`‎contrib/pgcrypto/crypt-md5.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -65,11 +65,17 @@ px_crypt_md5(const char pw, const char salt, char *passwd, unsigned dstlen)`
`65`	`65`	`/* get the length of the true salt */`
`66`	`66`	`sl=ep-sp;`
`67`	`67`
`68`		`-/* */`
	`68`	`+/we need two PX_MD objects/`
`69`	`69`	`err=px_find_digest("md5",&ctx);`
`70`	`70`	`if (err)`
`71`	`71`	`returnNULL;`
`72`	`72`	`err=px_find_digest("md5",&ctx1);`
	`73`	`+if (err)`
	`74`	`+{`
	`75`	`+/* this path is possible under low-memory circumstances */`
	`76`	`+px_md_free(ctx);`
	`77`	`+returnNULL;`
	`78`	`+}`
`73`	`79`
`74`	`80`	`/* The password first, since that is what is most unknown */`
`75`	`81`	`px_md_update(ctx, (constuint8*)pw,strlen(pw));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit02a75f8

File tree

1 file changed

1 file changed

`‎contrib/pgcrypto/crypt-md5.c`

0 commit comments