NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit029fac2

committed

Avoid use of CREATE OR REPLACE FUNCTION in extension installation files.

It was never terribly consistent to use OR REPLACE (because of the lack ofcomparable functionality for data types, operators, etc), andexperimentation shows that it's now positively pernicious in the extensionworld. We really want a failure to occur if there are any conflicts, elseit's unclear what the extension-ownership state of the conflicted objectought to be. Most of the time, CREATE EXTENSION will fail anyway becauseof conflicts on other object types, but an extension defining onlyfunctions can succeed, with bad results.

1 parent629b3af commit029fac2Copy full SHA for 029fac2

File tree

37 files changed

+922

-922

lines changed

contrib
- adminpack
  - adminpack--1.0.sql
- btree_gin
  - btree_gin--1.0.sql
- btree_gist
  - btree_gist--1.0.sql
- chkpass
  - chkpass--1.0.sql
- citext
  - citext--1.0.sql
- cube
  - cube--1.0.sql
- dblink
  - dblink--1.0.sql
- dict_int
  - dict_int--1.0.sql
- dict_xsyn
  - dict_xsyn--1.0.sql
- earthdistance
  - earthdistance--1.0.sql
- fuzzystrmatch
  - fuzzystrmatch--1.0.sql
- hstore
  - hstore--1.0.sql
- intagg
  - int_aggregate--1.0.sql
- intarray
  - intarray--1.0.sql
- isn
  - isn--1.0.sql
- lo
  - lo--1.0.sql
- ltree
  - ltree--1.0.sql
- pageinspect
  - pageinspect--1.0.sql
- pg_buffercache
  - pg_buffercache--1.0.sql
- pg_freespacemap
  - pg_freespacemap--1.0.sql
- pg_trgm
  - pg_trgm--1.0.sql
- pgcrypto
  - pgcrypto--1.0.sql
- pgrowlocks
  - pgrowlocks--1.0.sql
- pgstattuple
  - pgstattuple--1.0.sql
- seg
  - seg--1.0.sql
- spi
  - autoinc--1.0.sql
  - insert_username--1.0.sql
  - moddatetime--1.0.sql
  - refint--1.0.sql
  - timetravel--1.0.sql
- sslinfo
  - sslinfo--1.0.sql
- tablefunc
  - tablefunc--1.0.sql
- test_parser
  - test_parser--1.0.sql
- tsearch2
  - tsearch2--1.0.sql
- unaccent
  - unaccent--1.0.sql
- uuid-ossp
  - uuid-ossp--1.0.sql
- xml2
  - xml2--1.0.sql

37 files changed

+922

-922

lines changed

`‎contrib/adminpack/adminpack--1.0.sql`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,45 +6,45 @@`
`6`	`6`
`7`	`7`	`/* generic file access functions*/`
`8`	`8`
`9`		`-CREATEOR REPLACEFUNCTIONpg_catalog.pg_file_write(text,text, bool)`
	`9`	`+CREATEFUNCTIONpg_catalog.pg_file_write(text,text, bool)`
`10`	`10`	`RETURNSbigint`
`11`	`11`	`AS'MODULE_PATHNAME','pg_file_write'`
`12`	`12`	`LANGUAGE C VOLATILE STRICT;`
`13`	`13`
`14`		`-CREATEOR REPLACEFUNCTIONpg_catalog.pg_file_rename(text,text,text)`
	`14`	`+CREATEFUNCTIONpg_catalog.pg_file_rename(text,text,text)`
`15`	`15`	`RETURNS bool`
`16`	`16`	`AS'MODULE_PATHNAME','pg_file_rename'`
`17`	`17`	`LANGUAGE C VOLATILE;`
`18`	`18`
`19`		`-CREATEOR REPLACEFUNCTIONpg_catalog.pg_file_rename(text,text)`
	`19`	`+CREATEFUNCTIONpg_catalog.pg_file_rename(text,text)`
`20`	`20`	`RETURNS bool`
`21`	`21`	`AS'SELECT pg_catalog.pg_file_rename($1, $2, NULL::pg_catalog.text);'`
`22`	`22`	`LANGUAGE SQL VOLATILE STRICT;`
`23`	`23`
`24`		`-CREATEOR REPLACEFUNCTIONpg_catalog.pg_file_unlink(text)`
	`24`	`+CREATEFUNCTIONpg_catalog.pg_file_unlink(text)`
`25`	`25`	`RETURNS bool`
`26`	`26`	`AS'MODULE_PATHNAME','pg_file_unlink'`
`27`	`27`	`LANGUAGE C VOLATILE STRICT;`
`28`	`28`
`29`		`-CREATEOR REPLACEFUNCTIONpg_catalog.pg_logdir_ls()`
	`29`	`+CREATEFUNCTIONpg_catalog.pg_logdir_ls()`
`30`	`30`	`RETURNS setof record`
`31`	`31`	`AS'MODULE_PATHNAME','pg_logdir_ls'`
`32`	`32`	`LANGUAGE C VOLATILE STRICT;`
`33`	`33`
`34`	`34`
`35`	`35`	`/* Renaming of existing backend functions for pgAdmin compatibility*/`
`36`	`36`
`37`		`-CREATEOR REPLACEFUNCTIONpg_catalog.pg_file_read(text,bigint,bigint)`
	`37`	`+CREATEFUNCTIONpg_catalog.pg_file_read(text,bigint,bigint)`
`38`	`38`	`RETURNStext`
`39`	`39`	`AS'pg_read_file'`
`40`	`40`	`LANGUAGE INTERNAL VOLATILE STRICT;`
`41`	`41`
`42`		`-CREATEOR REPLACEFUNCTIONpg_catalog.pg_file_length(text)`
	`42`	`+CREATEFUNCTIONpg_catalog.pg_file_length(text)`
`43`	`43`	`RETURNSbigint`
`44`	`44`	`AS'SELECT size FROM pg_catalog.pg_stat_file($1)'`
`45`	`45`	`LANGUAGE SQL VOLATILE STRICT;`
`46`	`46`
`47`		`-CREATEOR REPLACEFUNCTIONpg_catalog.pg_logfile_rotate()`
	`47`	`+CREATEFUNCTIONpg_catalog.pg_logfile_rotate()`
`48`	`48`	`RETURNS int4`
`49`	`49`	`AS'pg_rotate_logfile'`
`50`	`50`	`LANGUAGE INTERNAL VOLATILE STRICT;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit029fac2

File tree

37 files changed

37 files changed

`‎contrib/adminpack/adminpack--1.0.sql`

0 commit comments