NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit01deec5

committed

Return a value from Install.pm's lcopy function

Commit3a7cc72 was a little over eager about adding an explicit returnto this function, whose value is checked in most call sites. This changereverses that and returns the expected value explicitly. It also adds acheck to the one call site lacking one.

1 parent6a75b58 commit01deec5Copy full SHA for 01deec5

File tree

1 file changed

-3

lines changed

src/tools/msvc
- Install.pm

1 file changed

-3

lines changed

`‎src/tools/msvc/Install.pm`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,10 @@ sub lcopy`
`37`	`37`	`unlink$target \|\| confess"Could not delete$target\n";`
`38`	`38`	`}`
`39`	`39`
`40`		`-copy($src,$target)`
	`40`	`+(my$retval =copy($src,$target))`
`41`	`41`	`\|\| confess"Could not copy$src to$target\n";`
`42`	`42`
`43`		`-return;`
	`43`	`+return$retval;`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`subInstall`
`@@ -200,7 +200,7 @@ sub CopyFiles`
`200`	`200`	`print".";`
`201`	`201`	`$f =$basedir .$f;`
`202`	`202`	`die"No file$f\n"if (!-f$f);`
`203`		`-lcopy($f,$target . basename($f));`
	`203`	`+lcopy($f,$target . basename($f)) \|\| croak"Could not copy$f:$!\n";`
`204`	`204`	`}`
`205`	`205`	`print"\n";`
`206`	`206`	`return;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit01deec5

File tree

1 file changed

1 file changed

`‎src/tools/msvc/Install.pm`

0 commit comments