Commit0161e52

committed

Update reference to sampling algorithm in analyze.c

Commit83e176e moved row sampling functions from analyze.c toutils/misc/sampling.c, but failed to update comment referring tothe sampling algorithm from Jeff Vitter's paper. Correct thecomment by pointing to utils/misc/sampling.c.Author: Etsuro FujitaDiscussion:https://postgr.es/m/CAPmGK154gp%2BQd%3DcorQOv%2BPmbyVyZBjp_%2Bhb766UJeD1e_ie6XQ%40mail.gmail.com

1 parenta559805 commit0161e52Copy full SHA for 0161e52

File tree

-7

lines changed

-7

lines changed

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -1173,13 +1173,13 @@ acquire_sample_rows(Relation onerel, int elevel,`
`1173`	`1173`	`* The first targrows sample rows are simply copied into the`
`1174`	`1174`	`* reservoir. Then we start replacing tuples in the sample`
`1175`	`1175`	`* until we reach the end of the relation. This algorithm is`
`1176`		`- * from Jeff Vitter's paper (see full citationbelow). It`
`1177`		`- * works by repeatedly computing the number of tuples to skip`
`1178`		`- *before selecting a tuple, which replaces a randomly chosen`
`1179`		`- *element of the reservoir (current set oftuples). At all`
`1180`		`- *times the reservoir is a true random sample ofthetuples`
`1181`		`- * we've passed over so far, so when we fall off the end of`
`1182`		`- * the relation we're done.`
	`1176`	`+ * from Jeff Vitter's paper (see full citationin`
	`1177`	`+ *utils/misc/sampling.c). Itworks by repeatedly computing`
	`1178`	`+ *the number of tuples to skip before selecting a tuple,`
	`1179`	`+ *which replaces a randomly chosen element ofthe reservoir`
	`1180`	`+ *(current set of tuples). At all timesthereservoir is a`
	`1181`	`+ *true random sample of the tupleswe've passed over so far,`
	`1182`	`+ *so when we fall off the end ofthe relation we're done.`
`1183`	`1183`	`*/`
`1184`	`1184`	`if (numrows<targrows)`
`1185`	`1185`	`rows[numrows++]=heap_copytuple(&targtuple);`

Comments

(0)