NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit014763e

committed

Fix use of dangling pointer in heap_delete() when logging replica identity

When logging the replica identity of a deleted tuple, XLOG_HEAP_DELETErecords include references of the old tuple. Its data is stored in anintermediate variable used to register this information for the WALrecord, but this variable gets away from the stack when the record getsactually inserted.Spotted by clang's AddressSanitizer.Author: Stas KelvishDiscussion:https://postgr.es/m/085C8825-AD86-4E93-AF80-E26CDF03D1EA@postgrespro.ruBackpatch-through: 9.4

1 parent650296f commit014763eCopy full SHA for 014763e

File tree

1 file changed

-2

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-2

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3265,6 +3265,7 @@ heap_delete(Relation relation, ItemPointer tid,`
`3265`	`3265`	`if (RelationNeedsWAL(relation))`
`3266`	`3266`	`{`
`3267`	`3267`	`xl_heap_deletexlrec;`
	`3268`	`+xl_heap_headerxlhdr;`
`3268`	`3269`	`XLogRecPtrrecptr;`
`3269`	`3270`
`3270`	`3271`	`/* For logical decode we need combocids to properly decode the catalog */`
`@@ -3295,8 +3296,6 @@ heap_delete(Relation relation, ItemPointer tid,`
`3295`	`3296`	`*/`
`3296`	`3297`	`if (old_key_tuple!=NULL)`
`3297`	`3298`	`{`
`3298`		`-xl_heap_headerxlhdr;`
`3299`		`-`
`3300`	`3299`	`xlhdr.t_infomask2=old_key_tuple->t_data->t_infomask2;`
`3301`	`3300`	`xlhdr.t_infomask=old_key_tuple->t_data->t_infomask;`
`3302`	`3301`	`xlhdr.t_hoff=old_key_tuple->t_data->t_hoff;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit014763e

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments