NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit013f423

committed

Fix pg_basebackup so that it accepts 0 as a valid compression level.

The help message for pg_basebackup specifies that the numbers 0 through 9are accepted as valid values of -Z option. But, previously -Z 0 was rejectedas an invalid compression level.Per discussion, it's better to make pg_basebackup treat 0 as validcompression level meaning no compression, like pg_dump.Back-patch to all supported versions.Reported-By: Jeff JanesReviewed-By: Amit KapilaDiscussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hVfM0B64b1_bPVKRqg@mail.gmail.com

1 parent9c6e594 commit013f423Copy full SHA for 013f423

File tree

2 files changed

-2

lines changed

doc/src/sgml/ref
- pg_basebackup.sgml
src/bin/pg_basebackup
- pg_basebackup.c

2 files changed

-2

lines changed

`‎doc/src/sgml/ref/pg_basebackup.sgml`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ PostgreSQL documentation`
`283`	`283`	`<listitem>`
`284`	`284`	`<para>`
`285`	`285`	`Enables gzip compression of tar file output, and specifies the`
`286`		`- compression level (1 through 9, 9 being best`
	`286`	`+ compression level (0 through 9, 0 being no compression and 9 being best`
`287`	`287`	`compression). Compression is only available when using the tar`
`288`	`288`	`format.`
`289`	`289`	`</para>`

`‎src/bin/pg_basebackup/pg_basebackup.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1789,7 +1789,7 @@ main(int argc, char **argv)`
`1789`	`1789`	`break;`
`1790`	`1790`	`case'Z':`
`1791`	`1791`	`compresslevel=atoi(optarg);`
`1792`		`-if (compresslevel <=0\|\|compresslevel>9)`
	`1792`	`+if (compresslevel<0\|\|compresslevel>9)`
`1793`	`1793`	`{`
`1794`	`1794`	`fprintf(stderr,_("%s: invalid compression level \"%s\"\n"),`
`1795`	`1795`	`progname,optarg);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit013f423

File tree

2 files changed

2 files changed

`‎doc/src/sgml/ref/pg_basebackup.sgml`

`‎src/bin/pg_basebackup/pg_basebackup.c`

0 commit comments