NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit01226c6

committed

Avoid use of Perl getprotobyname

getprotobyname returns undefined on some CI machines. It's not clearwhy. The code overall still works, but it raises a warning.In PostgreSQL C code, we always call socket() with 0 for the protocolargument, so we should be able to do the same in Perl (since the Perldocumentation says that the arguments of the socket function are thesame as in C). So do that, to avoid the issue.Reviewed-by: Andrew Dunstan <andrew@dunslane.net>Discussion:https://www.postgresql.org/message-id/flat/06f899fd-1826-05ab-42d6-adeb1fd5e200%40eisentraut.org

1 parentbf8bf6d commit01226c6Copy full SHA for 01226c6

File tree

1 file changed

-2

lines changed

src/test/perl/PostgreSQL/Test
- Cluster.pm

1 file changed

-2

lines changed

`‎src/test/perl/PostgreSQL/Test/Cluster.pm`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1570,9 +1570,8 @@ sub can_bind`
`1570`	`1570`	`my ($host,$port) =@_;`
`1571`	`1571`	`my$iaddr = inet_aton($host);`
`1572`	`1572`	`my$paddr = sockaddr_in($port,$iaddr);`
`1573`		`-my$proto =getprotobyname("tcp");`
`1574`	`1573`
`1575`		`-socket(SOCK, PF_INET, SOCK_STREAM,$proto)`
	`1574`	`+socket(SOCK, PF_INET, SOCK_STREAM,0)`
`1576`	`1575`	`ordie"socket failed:$!";`
`1577`	`1576`
`1578`	`1577`	`# As in postmaster, don't use SO_REUSEADDR on Windows`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit01226c6

File tree

1 file changed

1 file changed

`‎src/test/perl/PostgreSQL/Test/Cluster.pm`

0 commit comments