forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit00b0e72
committed
ecpg: clean up documentation of parse.pl, and add more input checking.
README.parser is the user's manual, such as it is, for parse.pl.It's rather poorly written if you ask me; so try to improve it.(More could be written here, but this at least covers the sameinfo in a more organized fashion.)Also, the single solitary line of usage info in parse.pl itselfwas a lie. Replace.Add some error checks that the ecpg.addons entries meet the syntaxrules set forth in README.parser. One of them didn't, butaccidentally worked anyway because the logic in include_addon issuch that 'block' is the default behavior.Also add a cross-check that each ecpg.addons entry is matched exactlyonce in the backend grammar. This exposed that there are two deadentries there --- they are dead because the %replace_types table inparse.pl causes their nonterminals to be ignored altogether.Removing them doesn't change the generated preproc.y file.(This implies that check_rules.pl is completely worthless and shouldbe nuked: it adds build cycles and maintenance effort while failingto reliably accomplish its one job of detecting dead rules. I'lldo that separately.)Discussion:https://postgr.es/m/2011420.1713493114@sss.pgh.pa.us1 parent7be4ba4 commit00b0e72
File tree
3 files changed
+123
-65
lines changed- src/interfaces/ecpg/preproc
3 files changed
+123
-65
lines changedLines changed: 77 additions & 42 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1 |
| - | |
2 |
| - | |
3 |
| - | |
4 |
| - | |
5 |
| - | |
6 |
| - | |
7 |
| - | |
8 |
| - | |
9 |
| - | |
10 |
| - | |
11 |
| - | |
12 |
| - | |
13 |
| - | |
14 |
| - | |
15 |
| - | |
16 |
| - | |
17 |
| - | |
18 |
| - | |
19 |
| - | |
20 |
| - | |
21 |
| - | |
22 |
| - | |
23 |
| - | |
24 |
| - | |
25 |
| - | |
26 |
| - | |
27 |
| - | |
28 |
| - | |
29 |
| - | |
30 |
| - | |
31 |
| - | |
32 |
| - | |
33 |
| - | |
34 |
| - | |
35 |
| - | |
36 |
| - | |
37 |
| - | |
38 |
| - | |
39 |
| - | |
40 |
| - | |
41 |
| - | |
42 |
| - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + |
Lines changed: 1 addition & 10 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
497 | 497 |
| |
498 | 498 |
| |
499 | 499 |
| |
500 |
| - | |
| 500 | + | |
501 | 501 |
| |
502 | 502 |
| |
503 | 503 |
| |
| |||
510 | 510 |
| |
511 | 511 |
| |
512 | 512 |
| |
513 |
| - | |
514 |
| - | |
515 |
| - | |
516 |
| - | |
517 |
| - | |
518 |
| - | |
519 |
| - | |
520 |
| - | |
521 |
| - | |
522 | 513 |
| |
523 | 514 |
| |
524 | 515 |
| |
|
Lines changed: 45 additions & 13 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1 | 1 |
| |
2 | 2 |
| |
3 |
| - | |
4 |
| - | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
5 | 11 |
| |
6 | 12 |
| |
7 | 13 |
| |
| |||
148 | 154 |
| |
149 | 155 |
| |
150 | 156 |
| |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
151 | 165 |
| |
152 | 166 |
| |
153 | 167 |
| |
| |||
487 | 501 |
| |
488 | 502 |
| |
489 | 503 |
| |
490 |
| - | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
491 | 508 |
| |
492 | 509 |
| |
493 | 510 |
| |
| |||
668 | 685 |
| |
669 | 686 |
| |
670 | 687 |
| |
671 |
| - | |
| 688 | + | |
672 | 689 |
| |
673 |
| - | |
674 |
| - | |
| 690 | + | |
| 691 | + | |
675 | 692 |
| |
676 | 693 |
| |
677 | 694 |
| |
| |||
681 | 698 |
| |
682 | 699 |
| |
683 | 700 |
| |
684 |
| - | |
685 |
| - | |
686 |
| - | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
687 | 705 |
| |
688 |
| - | |
| 706 | + | |
689 | 707 |
| |
690 | 708 |
| |
691 | 709 |
| |
692 |
| - | |
| 710 | + | |
693 | 711 |
| |
| 712 | + | |
694 | 713 |
| |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
695 | 720 |
| |
696 | 721 |
| |
697 | 722 |
| |
| |||
701 | 726 |
| |
702 | 727 |
| |
703 | 728 |
| |
704 |
| - | |
| 729 | + | |
705 | 730 |
| |
706 | 731 |
| |
707 |
| - | |
| 732 | + | |
708 | 733 |
| |
709 | 734 |
| |
710 | 735 |
| |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
711 | 741 |
| |
712 | 742 |
| |
| 743 | + | |
713 | 744 |
| |
714 | 745 |
| |
715 | 746 |
| |
716 | 747 |
| |
717 | 748 |
| |
| 749 | + | |
718 | 750 |
| |
719 | 751 |
| |
720 | 752 |
| |
|
0 commit comments
Comments
(0)