Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit00713cb

Browse files
committed
Fix code that incorrectly assumed a 'char foo[N]' local variable would
be aligned on a word boundary. Per report from Steve Nicolai.
1 parent6ba0f31 commit00713cb

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

‎src/backend/access/heap/tuptoaster.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.20 2001/03/23 04:49:51 momjian Exp $
11+
* $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.21 2001/03/25 00:45:20 tgl Exp $
1212
*
1313
*
1414
* INTERFACE ROUTINES
@@ -745,7 +745,10 @@ toast_save_datum(Relation rel, Oid mainoid, int16 attno, Datum value)
745745
Datumt_values[3];
746746
chart_nulls[3];
747747
varattrib*result;
748-
charchunk_data[VARHDRSZ+TOAST_MAX_CHUNK_SIZE];
748+
struct {
749+
structvarlenahdr;
750+
chardata[TOAST_MAX_CHUNK_SIZE];
751+
}chunk_data;
749752
int32chunk_size;
750753
int32chunk_seq=0;
751754
char*data_p;
@@ -780,7 +783,7 @@ toast_save_datum(Relation rel, Oid mainoid, int16 attno, Datum value)
780783
* Initialize constant parts of the tuple data
781784
*/
782785
t_values[0]=ObjectIdGetDatum(result->va_content.va_external.va_valueid);
783-
t_values[2]=PointerGetDatum(chunk_data);
786+
t_values[2]=PointerGetDatum(&chunk_data);
784787
t_nulls[0]=' ';
785788
t_nulls[1]=' ';
786789
t_nulls[2]=' ';
@@ -813,8 +816,8 @@ toast_save_datum(Relation rel, Oid mainoid, int16 attno, Datum value)
813816
* Build a tuple
814817
*/
815818
t_values[1]=Int32GetDatum(chunk_seq++);
816-
VARATT_SIZEP(chunk_data)=chunk_size+VARHDRSZ;
817-
memcpy(VARATT_DATA(chunk_data),data_p,chunk_size);
819+
VARATT_SIZEP(&chunk_data)=chunk_size+VARHDRSZ;
820+
memcpy(VARATT_DATA(&chunk_data),data_p,chunk_size);
818821
toasttup=heap_formtuple(toasttupDesc,t_values,t_nulls);
819822
if (!HeapTupleIsValid(toasttup))
820823
elog(ERROR,"Failed to build TOAST tuple");

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp