NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit0044f45

committed

Ignore extra subquery outputs in set_subquery_size_estimates().

In commit0f61d4d, I added code to copy upcolumn width estimates for each column of a subquery. That code supposedthat the subquery couldn't have any output columns that didn't correspondto known columns of the current query level --- which is true when a queryis parsed from scratch, but the assumption fails when planning a view thatdepends on another view that's been redefined (adding output columns) sincethe upper view was made. This results in an assertion failure or even acrash, as per bug #8025 from lindebg. Remove the Assert and instead skipthe column if its resno is out of the expected range.

1 parent4d001c3 commit0044f45Copy full SHA for 0044f45

File tree

1 file changed

-1

lines changed

src/backend/optimizer/path
- costsize.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/path/costsize.c`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3700,6 +3700,15 @@ set_subquery_size_estimates(PlannerInfo root, RelOptInfo rel)`
`3700`	`3700`	`if (te->resjunk)`
`3701`	`3701`	`continue;`
`3702`	`3702`
	`3703`	`+/*`
	`3704`	`+ * The subquery could be an expansion of a view that's had columns`
	`3705`	`+ * added to it since the current query was parsed, so that there are`
	`3706`	`+ * non-junk tlist columns in it that don't correspond to any column`
	`3707`	`+ * visible at our query level. Ignore such columns.`
	`3708`	`+ */`
	`3709`	`+if (te->resno<rel->min_attr\|\|te->resno>rel->max_attr)`
	`3710`	`+continue;`
	`3711`	`+`
`3703`	`3712`	`/*`
`3704`	`3713`	`* XXX This currently doesn't work for subqueries containing set`
`3705`	`3714`	`* operations, because the Vars in their tlists are bogus references`
`@@ -3721,7 +3730,6 @@ set_subquery_size_estimates(PlannerInfo root, RelOptInfo rel)`
`3721`	`3730`
`3722`	`3731`	`item_width=subrel->attr_widths[var->varattno-subrel->min_attr];`
`3723`	`3732`	`}`
`3724`		`-Assert(te->resno >=rel->min_attr&&te->resno <=rel->max_attr);`
`3725`	`3733`	`rel->attr_widths[te->resno-rel->min_attr]=item_width;`
`3726`	`3734`	`}`
`3727`	`3735`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0044f45

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/costsize.c`

0 commit comments