NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit002962d

committed

Fix test_session_hooks with parallel workers

Several buildfarm machines have been complaining about the new moduletest_session_hooks to be unstable, like crake and thorntail. The issuewas that the module was trying to log some start and end sessionactivity for parallel workers, which makes little sense as they don'tsupport DML, so just prevent this pattern to happen in the module.This could be reproduced by enforcing force_parallel_mode=regress, whichis the value used by some of the buildfarm members.Discussion:https://postgr.es/m/20191001045246.GF2781@paquier.xyz

1 parente788bd9 commit002962dCopy full SHA for 002962d

File tree

1 file changed

-0

lines changed

src/test/modules/test_session_hooks
- test_session_hooks.c

1 file changed

-0

lines changed

`‎src/test/modules/test_session_hooks/test_session_hooks.c`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`*/`
`14`	`14`	`#include"postgres.h"`
`15`	`15`
	`16`	`+#include"access/parallel.h"`
`16`	`17`	`#include"access/xact.h"`
`17`	`18`	`#include"commands/dbcommands.h"`
`18`	`19`	`#include"executor/spi.h"`
`@@ -89,6 +90,10 @@ sample_session_start_hook(void)`
`89`	`90`	`if (!OidIsValid(MyDatabaseId))`
`90`	`91`	`return;`
`91`	`92`
	`93`	`+/* no parallel workers */`
	`94`	`+if (IsParallelWorker())`
	`95`	`+return;`
	`96`	`+`
`92`	`97`	`register_session_hook("START");`
`93`	`98`	`}`
`94`	`99`
`@@ -107,6 +112,10 @@ sample_session_end_hook(void)`
`107`	`112`	`if (!OidIsValid(MyDatabaseId))`
`108`	`113`	`return;`
`109`	`114`
	`115`	`+/* no parallel workers */`
	`116`	`+if (IsParallelWorker())`
	`117`	`+return;`
	`118`	`+`
`110`	`119`	`register_session_hook("END");`
`111`	`120`	`}`
`112`	`121`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit002962d

File tree

1 file changed

1 file changed

`‎src/test/modules/test_session_hooks/test_session_hooks.c`

0 commit comments