NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit000efc3

committed

In rewriteheap.c (used by VACUUM FULL and CLUSTER), calculate the tuple

length stored in the line pointer the same way it's calculated in the normalheap_insert() codepath. As noted by Jeff Davis, the length stored byraw_heap_insert() included padding but the one stored by the normal codepathdid not. While the mismatch seems to be harmless, inconsistency isn't good,and the normal codepath has received a lot more testing over the years.Backpatch to 8.3 where the heap rewrite code was introduced.

1 parent73bc521 commit000efc3Copy full SHA for 000efc3

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- rewriteheap.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/rewriteheap.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -641,7 +641,7 @@ raw_heap_insert(RewriteState state, HeapTuple tup)`
`641`	`641`	`}`
`642`	`642`
`643`	`643`	`/* And now we can insert the tuple into the page */`
`644`		`-newoff=PageAddItem(page, (Item)heaptup->t_data,len,`
	`644`	`+newoff=PageAddItem(page, (Item)heaptup->t_data,heaptup->t_len,`
`645`	`645`	`InvalidOffsetNumber, false, true);`
`646`	`646`	`if (newoff==InvalidOffsetNumber)`
`647`	`647`	`elog(ERROR,"failed to add tuple");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit000efc3

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/rewriteheap.c`

0 commit comments