Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add function to create spoly from an array of numbers in radians#96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

esabol
Copy link
Contributor

As discussed in issue#95, this pull request adds a constructor function to create an spoly from an array of numbers in radians. It is very similar to spoly_deg() except without the calls todeg_to_rad().

Question 1: Can the spoly(float8[]) function be marked PARALLEL SAFE? My reading of the documentation for PARALLEL SAFE doesn't mention anything about accessing arrays or allocating memory, so I think it should be.

Question 2: Can it be marked STRICT?select spoly(NULL::float8[]) returns null, I believe.

If the answer to either or both questions, I would like to make the same change(s) tospoly_deg also.

@df7cb
Copy link
Contributor

I believe the answer to both question is "yes".

Mind that besides the parameter being NULL, individual array elements might also be NULL.

vitcpp reacted with thumbs up emoji

@vitcpp
Copy link
Contributor

@esabol I think, everything ok except of some trivial formatting changes. Thank you!

esabol reacted with thumbs up emoji

@vitcpp
Copy link
Contributor

@esabol I'm ok to accept the patch. Could you please squash the commits?

esabol reacted with thumbs up emoji

@esabolesabolforce-pushed theadd-spoly-array-constructor branch from2cbb5b0 to0fcfa36CompareNovember 1, 2023 20:04
@esabol
Copy link
ContributorAuthor

Rebased and squashed. Ready to merge whenever you are. Thank you for your reviews,@vitcpp !

vitcpp reacted with thumbs up emoji

@vitcpp
Copy link
Contributor

It seems I'm the only reviewer. Lets merge it, since the risks to break the pgpshere are minimal.

esabol reacted with thumbs up emoji

@vitcppvitcpp merged commit81939cf intopostgrespro:masterNov 3, 2023
@esabolesabol deleted the add-spoly-array-constructor branchNovember 3, 2023 06:02
@vitcppvitcpp mentioned this pull requestNov 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vitcppvitcppvitcpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@esabol@df7cb@vitcpp
[8]ページ先頭
©2009-2025 Movatter.jp