Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add pipeline for docs using GitHub Pages#73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vitcpp merged 1 commit intopostgrespro:masterfromborodun:github-pages
Oct 2, 2023

Conversation

borodun
Copy link
Contributor

Build and deploy docs to GitHub Pages. This workflow will deploy for master branch. For now, it hosts doc/html directory, so only the last version will be available. How necessary is it to organize the deployment of documentation with previous versions?

Copy link
Contributor

@esabolesabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is great! Thank you!

I think we only care about the latest documentation?

Is there a way to test this before we merge the PR? Otherwise, we can always tweak after merging.

@borodun
Copy link
ContributorAuthor

@esabol, I've tested it on my fork by removingbranches: master:https://github.com/borodun/pgsphere/actions/runs/6339680394. Docs were deployed tohttps://borodun.github.io/pgsphere/.

esabol reacted with thumbs up emoji

Copy link
Contributor

@esabolesabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! Thank you!

@vitcppvitcpp merged commit1066514 intopostgrespro:masterOct 2, 2023
@esabol
Copy link
Contributor

esabol commentedOct 4, 2023
edited
Loading

So what's the URL of the GitHub Pages documentation? We should add this URL to the README and possibly the documentation itself, I think. And the "About" box on the front page of the repository.

I triedhttps://postgrespro.github.io/pgsphere/ and got a 404 error, so that must not be it?

@vitcpp
Copy link
Contributor

@esabol,@borodun It should behttps://postgrespro.github.io/pgsphere/ . It worked yesterday before the last merge. But it displays 404 now unfortunately. We will check and fix it. It may be the result of the changes in the master branch (changed version number). Thank you for reporting!

esabol reacted with thumbs up emoji

@borodun
Copy link
ContributorAuthor

@esabol,@vitcpp It looks like the following jobhttps://github.com/postgrespro/pgsphere/actions/runs/6403043991 (default Jekyll workflow) was executed afterhttps://github.com/postgrespro/pgsphere/actions/runs/6403044188 and erased all static files. After re-run, docs appeared again onhttps://postgrespro.github.io/pgsphere/. We need to disable this workflow:https://github.com/postgrespro/pgsphere/actions/workflows/pages/pages-build-deployment. Seems like it was added due to mistake in repo setting, because it doesn't have a corresponding workflow file in.github/workflows directory.

@esabol
Copy link
Contributor

esabol commentedOct 5, 2023
edited
Loading

I was readingthe documentation on this yesterday, and it said something about creating a.nojekyll file. I didn't understand why, but maybe this is the reason?

@borodun
Copy link
ContributorAuthor

@esabol, thank you! As I understand from the docs, this file is only used when publishing Github Pages from a branch. We have tried to change repo settings to use Github Actions to publish Pages. We will see if this helped when new commits will be added to master. So, for now, this file won't be necessary, I think.

esabol reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@esabolesabolesabol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@borodun@esabol@vitcpp

[8]ページ先頭

©2009-2025 Movatter.jp