Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add GitHub Actions pipeline for pgSphere#69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vitcpp merged 1 commit intopostgrespro:masterfromborodun:github-actions
Sep 27, 2023

Conversation

borodun
Copy link
Contributor

Use GitHub Actions for pgSphere pipeline. At this moment, builds with HEALPix are failing due to compilation warning, but#68 should fix this.

Copy link
Contributor

@esabolesabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I love it! Fantastic contribution!

vitcpp reacted with thumbs up emoji
@esabol
Copy link
Contributor

esabol commentedSep 26, 2023
edited
Loading

I also dream of a GitHub Actions pipeline which, on merges to the master branch, uploads the latest documentation to the GitHub Pages associated with this repository. Could you help with that? That's probably a separate pipeline though.

@esabol
Copy link
Contributor

@borodun: Actually, I think "make test" should come before "make install"?

Also, I am curious as to why you chosefail-fast: false?

@borodun
Copy link
ContributorAuthor

@esabol, I movedmake test beforemake install. Aboutfail-fast: false: I wanted to make the CI behavior the same as the current Travis pipeline, it will not cancel jobs if other jobs fail first. In my opinion, this will help to get more informative pipeline runs.

esabol reacted with thumbs up emoji

@borodun
Copy link
ContributorAuthor

@esabol, regarding the pipeline for docs: that’s the plan. We need to organize access to GitHub Pages for this repository. This is a more administrative issue. We want to get this done as soon as possible.

@vitcppvitcpp merged commitdbd564d intopostgrespro:masterSep 27, 2023
@esabol
Copy link
Contributor

The new GitHub Actions pipeline doesn't seem to be working in PR#65, unfortunately. Very weird error that I've not encountered before in my GitHub Actions.

@vitcpp
Copy link
Contributor

@esabol,@borodun It seems the problem is in line 63 of build-and-check.yml: github.ref_name is 65/merge. It seems the / symbol should be replaced with some other acceptable symbol or another var should be used.

esabol reacted with thumbs up emoji

@esabol
Copy link
Contributor

Changing the '/' to a '-' in$github_ref_name can be done as shown here:

https://github.com/mbiagetti/github-action-poc/pull/2/files

But that method seemsvery convoluted and annoying. Would this method work?

https://stackoverflow.com/a/67290085/5153779

@borodun
Copy link
ContributorAuthor

We can use something likehttps://github.com/marketplace/actions/github-slug-action to create slugged versions of variables. We can add:

- name: Inject slug/short variables  uses: rlespinasse/github-slug-action@v4

And change${{ github.ref_name }} to${{ env.GITHUB_REF_SLUG_URL }}

I'll create PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@esabolesabolesabol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@borodun@esabol@vitcpp

[8]ページ先頭

©2009-2025 Movatter.jp