- Notifications
You must be signed in to change notification settings - Fork15
[ISSUE #42] Fix compiler warning#47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
18f7b6e tocbf89a8Compare
esabol left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me! Thank you,@stepan-neretin7 !
vitcpp left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In general, I'm ok with the fix. One trivial concern is the chosen variable name, but I do not see the sense in asking authors about it. It may be easily changed in the future.
No description provided.