NotificationsYou must be signed in to change notification settings
Fork15
Star22

Created some tests for contains and overlap operations to check DE-9IM compliance#44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vitcpp merged 1 commit intopostgrespro:masterfrom3Davydov:contains_and_overlaps_test

Aug 8, 2023

Merged

Created some tests for contains and overlap operations to check DE-9IM compliance#44

vitcpp merged 1 commit intopostgrespro:masterfrom3Davydov:contains_and_overlaps_test

Aug 8, 2023

Conversation

Copy link

Contributor

3Davydov commentedAug 4, 2023

No description provided.

Copy link

Contributor

esabol commentedAug 4, 2023

Thank you for this,@3Davydov ! I love more tests.

There's already a "contains_ops" and a "contains_ops_compat" files for testing. I wonder if it would be appropriate to put your "contains" tests in one of those files?

Copy link

ContributorAuthor

Hello,@esabol !
I think it's still worth making a separate file for this. The tests in the "contains_ops" and "contains_ops_compat" files are relevant only for the current logic.
If it is decided to switch to the DE-9IM model, then it will be necessary first of all to focus on the tests from "contains", and it may be more convenient to work with a separate file.

esabol approved these changes

Aug 4, 2023

View reviewed changes

vitcpp requested changes

Aug 5, 2023

View reviewed changes

Copy link

Contributor

vitcpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@esabol I propose to accept this PR with some trivial changes. Tests do not affect functionality but can be used to learn semantics of operations. I have some ideas how to improve and reorganise it.@3Davydov did a nice analysis of existing algorithms and found that they are not fully compliant with the semantics of operations on figures as described in the DE-9IM model (and OSG Simple Feature Specification). I understand that we can not just change the behaviour of operations to make it compliant but we can update the docs with some notes about differences with reference models.