@stepan-neretin7 In general, I'm ok with your patch except of some cosmetic issues (float -> float8 is important). To create a complete patch I would ask to change the version to 1.3.0 (API is changed) and create a new upgrade script with name pg_sphere--1.2.3--1.3.0.sql.in in upgrade_scripts subdirectory. Makefile should also be updated to add support for the new upgrade script. Upgrade scripts are used to alter the existing schema of previous version to the new schema. In our case we have to create new functions in the new upgrade script. Thank you!

@vitcpp I have updated the version

I also added the spoly_deg function, which accepts, as in the pr of 5 years ago, an array of float8, where there are consecutive pairs in the sequence of two float8 per point for the polygon

I also added the spoly_deg function, which accepts, as in the pr of 5 years ago, an array of float8, where there are consecutive pairs in the sequence of two float8 per point for the polygon

Thank you! I was just going to suggest that adding aspoly_deg() for the sake of completeness might be a good idea. 😄

I also added the spoly_deg function, which accepts, as in the pr of 5 years ago, an array of float8, where there are consecutive pairs in the sequence of two float8 per point for the polygon

Thank you! I was just going to suggest that adding aspoly_deg() for the sake of completeness might be a good idea. smile

Sorry, I didn't really get your message. So I guessed your thought? :D
And how do you like pr in general, how about approve?

And how do you like pr in general, how about approve?

Sorry, I thought I already did. Approved!

Oh, sorry, I found one more minor thing: I saw you fixed the "radius must be not greater than 90 degrees" error message, but there is another version of that error on line 84 of src/circle.c. Could you fix line 84 similar to how you fixed line 366?

Oh, sorry, I found one more minor thing: I saw you fixed the "radius must be not greater than 90 degrees" error message, but there is another version of that error on line 84 of src/circle.c. Could you fix line 84 similar to how you fixed line 366?

Of course, I've already fixed it. However, it is strange that there are no tests specifically for this error in circle.sql.
I can add if necessary and it will be appropriate in this pull request

@stepan-neretin7 I added some review comments. Most of the comments are minor and related to the code formatting. I would propose to work out these comments. Another performance issue I've found is in spherepoly_deg(). It will work as it is now but it is not an effective solution. Anyway, I'm ok to apply PR without redesign of this function.

I corrected all the comments
Look again, please@esabol

Sorry for trivial coding style issues. I fixed it@esabol