NotificationsYou must be signed in to change notification settings
Fork15
Star22

[ISSUE #17] Corrected the angle functions to fix the incorrected results strans function according to the documentation.#32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vitcpp merged 2 commits intopostgrespro:masterfromdura0ok:17_fix_theta_function

Jul 24, 2023

Merged

[ISSUE #17] Corrected the angle functions to fix the incorrected results strans function according to the documentation.#32

vitcpp merged 2 commits intopostgrespro:masterfromdura0ok:17_fix_theta_function

Jul 24, 2023

Conversation

Copy link

dura0ok commentedJul 21, 2023

The problem was that our corners are float8, and for some reason pointers were returned.

dura0ok changed the title~~[ISSUE #17] Corrected the angle functions to fix the incorrected results strans function according to the documentation.~~[ISSUE-17] Corrected the angle functions to fix the incorrected results strans function according to the documentation.

Jul 21, 2023

dura0ok changed the title~~[ISSUE-17] Corrected the angle functions to fix the incorrected results strans function according to the documentation.~~[ISSUE #17] Corrected the angle functions to fix the incorrected results strans function according to the documentation.

Jul 21, 2023

esabol approved these changes

Jul 21, 2023

View reviewed changes

vitcpp approved these changes

Jul 23, 2023

View reviewed changes

Copy link

Contributor

vitcpp commentedJul 23, 2023

I propose to change version to 1.2.3 (increment patch number) before merge.

@stepan-neretin7 Could you please change the version number to 1.2.3 in the following places:

Makefile: change PGSPHERE_VERSION to 1.2.3
pg_sphere.control: change default_version to 1.2.3

dura0ok force-pushed the17_fix_theta_function branch 2 times, most recently from714c473 toca147efCompare

July 23, 2023 16:53

esabol suggested changes

Jul 23, 2023

View reviewed changes

sql/euler.sql OutdatedShow resolvedHide resolved

Return value from function, which should return angle must be float, …

ba50fcb

…not pointer

dura0ok force-pushed the17_fix_theta_function branch fromca147ef toba50fcbCompare

July 24, 2023 02:05

Create Upgrade script

bc591b8

Copy link

Contributor

vitcpp commentedJul 24, 2023

@stepan-neretin7 Thank you for the fix! It works on my side. I think the patch is ready for merge.

The decision to increment version number was made because the fix is important. I propose to define version 1.2.3 as stable and assign the tag '1.2.3'. Stub upgrade script was added to make upgrade process to complete without errors.